Attention is currently required from: Intel coreboot Reviewers, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Paul Menzel, Pranava Y N.
Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85131?usp=email )
Change subject: soc/intel/pantherlake: Bind SoC config VR settings to respective UPD
......................................................................
Patch Set 12: Code-Review+2
(1 comment)
Patchset:
PS6:
We needed to wait for 3015 for the `CepEnable` UPD to even exist.
https://review.coreboot.org/c/coreboot/+/86258 introduces 3015 Partial headers. However, in order to fully utilize this feature, we integrated a CL from a subsequent version of the FSP, which exports some extra UPDs. While UPDs were present in version 3015, they are not naively accessible .
To legitimate CL 86258, we can port the extra UPD exportation CL to Google repository once a 3015 is available in this repository.
Can you please push the UPD changes in Chrome-Internal and get the review going? Till then, if possible, please hold this CL on the patch train. After the FSP 3-15 merge is done, we’ll start with eSOL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85131?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie72e4725cb97b4af7843a43eeaedd687d28b6752
Gerrit-Change-Number: 85131
Gerrit-PatchSet: 12
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Wed, 19 Feb 2025 05:20:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com