Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Hannah Williams, Paul Menzel.
Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84103?usp=email )
Change subject: soc/intel/common/block/acpi: Add GPE1 blocks to ACPI FADT table
......................................................................
Patch Set 10:
(2 comments)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/84103/comment/8eb53f0b_1a369903?usp... :
PS7, Line 121: if (CONFIG(SOC_INTEL_COMMON_BLOCK_ACPI_USE_GPE1)) {
Subrata,
agree. We will need only _HAVE_GPE1 flag as long as the SOC header uses _HVAE_GPE1 flag for providing GPE1 defines. For the case of not using GPE1 in PTL, we will unset this flag.
yes, that makes more sense to me. but note if you wish to make `_HAVE_GPE1` Kconfig configurable then better to select from mainboard and not SoC default.
https://review.coreboot.org/c/coreboot/+/84103/comment/e5fac0a3_01b563a3?usp... :
PS7, Line 128: 8
yes.
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84103?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia6928c35b86f4a2243d58597b17b2a3a5f54271e
Gerrit-Change-Number: 84103
Gerrit-PatchSet: 10
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Sat, 31 Aug 2024 08:03:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com