Attention is currently required from: Arthur Heymans, Martin L Roth, Martin Roth, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76511?usp=email )
Change subject: vendorcode/amd: Hook up opensil ......................................................................
Patch Set 13:
(4 comments)
File src/vendorcode/amd/opensil/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/76511/comment/6372aa1b_c426286b : PS13, Line 15: else
it would make the code more readable to add a comment that this os the else branch for the if CONFIG […]
Done
https://review.coreboot.org/c/coreboot/+/76511/comment/9113c640_e4d8a9c7 : PS13, Line 24: ifeq ($(CONFIG_OPENSIL_DEBUG_OUTPUT),y)
add an empty line before this one, to have this if block that's unrelated to the ones before it sepa […]
Done
https://review.coreboot.org/c/coreboot/+/76511/comment/e19b39ad_a3d3c100 : PS13, Line 30: ifeq ($(shell printf %.1s "$(obj)"),/)
still need to figure out what this is doing exactly. […]
Done
https://review.coreboot.org/c/coreboot/+/76511/comment/34de70ab_00082f2a : PS13, Line 46: $(CONFIG_C_ENV_BOOTBLOCK_SIZE)
this should either be $(bios_size) or the bios_size definition in line 41 should be dropped
used $(bios_size) here