Change in coreboot[master]: mb/google/dedede/var/magolor: Select camera module based on SSFC value
Attention is currently required from: Furquan Shaikh, Martin Roth, Andy Yeh, Sugnan Prabhu S, Rizwan Qureshi, ShawnX Tu. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50261 )
Change subject: mb/google/dedede/var/magolor: Select camera module based on SSFC value ......................................................................
Patch Set 10:
(2 comments)
File src/mainboard/google/dedede/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/50261/comment/4ddccd53_49956c67 PS10, Line 78: EC_GOOGLE_CHROMEEC_INCLUDE_SSFC_IN_FW_CONFIG Can be moved to Kconfig and selected under BOARD_GOOGLE_BASEBOARD_DEDEDE
File src/mainboard/google/dedede/variants/magolor/camera_config.c:
https://review.coreboot.org/c/coreboot/+/50261/comment/3a8d91d2_3eccdfd8 PS9, Line 47: static struct drivers_intel_mipi_camera_config ovti5675_driver_info = {
The board_id is 2 in my tested DUT.
Given the power sequence for both the cameras are identical, it is ok to go ahead with the default camera option. We can revisit later if there are new camera sources in the future.
Can you check one last time with the factory provisioning team and ensure that there are no weird behavior during the factory flow with camera source unprovisioned - especially identifying the camera source and provisioning SSFC accordingly? If there are no issues with the factory flow as well, then we can go ahead with this CL as is.
-
Karthik Ramasubramanian (Code Review)