Change in ...coreboot[master]: nb/amd/amdmct/mct_ddr3/mct_d.c: Remove variable set but not used

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32972

Change subject: nb/amd/amdmct/mct_ddr3/mct_d.c: Remove variable set but not used
......................................................................

nb/amd/amdmct/mct_ddr3/mct_d.c: Remove variable set but not used

Change-Id: Icd9c0541d9006f4ebddcefff9d2355056af0c5c4
Signed-off-by: Elyes HAOUAS 
---
M src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/32972/1

diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
index 74e5234..853419e 100644
--- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
+++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
@@ -3808,7 +3808,7 @@
 {
    u8 Node;
    u32 NextBase, BottomIO;
-	u8 _MemHoleRemap, DramHoleBase, DramHoleOffset;
+	u8 _MemHoleRemap, DramHoleBase;
    u32 HoleSize, DramSelBaseAddr;

u32 val;
@@ -3867,7 +3867,6 @@
    				if ((DramSelBaseAddr > 0) && (DramSelBaseAddr < BottomIO))
    					base = DramSelBaseAddr;
    				val = ((base + HoleSize) >> (24-8)) & 0xFF;
-					DramHoleOffset = val;
    				val <<= 8; /* shl 16, rol 24 */
    				val |= DramHoleBase << 24;
    				val |= 1  << DramHoleValid;

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32972 )

Change subject: nb/amd/amdmct/mct_ddr3/mct_d.c: Remove variable set but not used
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32972 )

Change subject: nb/amd/amdmct/mct_ddr3/mct_d.c: Remove variable set but not used
......................................................................

nb/amd/amdmct/mct_ddr3/mct_d.c: Remove variable set but not used

Change-Id: Icd9c0541d9006f4ebddcefff9d2355056af0c5c4
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32972
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
index 42e91b6..5be4566 100644
--- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
+++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
@@ -3810,7 +3810,7 @@
 {
    u8 Node;
    u32 NextBase, BottomIO;
-	u8 _MemHoleRemap, DramHoleBase, DramHoleOffset;
+	u8 _MemHoleRemap, DramHoleBase;
    u32 HoleSize, DramSelBaseAddr;

u32 val;
@@ -3869,7 +3869,6 @@
    				if ((DramSelBaseAddr > 0) && (DramSelBaseAddr < BottomIO))
    					base = DramSelBaseAddr;
    				val = ((base + HoleSize) >> (24-8)) & 0xFF;
-					DramHoleOffset = val;
    				val <<= 8; /* shl 16, rol 24 */
    				val |= DramHoleBase << 24;
    				val |= 1  << DramHoleValid;