HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32945
Change subject: drivers/aspeed/ast2050: Remove variable set but not used ......................................................................
drivers/aspeed/ast2050: Remove variable set but not used
Change-Id: Iedda92edf8c4eb7be037dcc0faa6fe8aa0c0754c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/aspeed/ast2050/ast2050.c 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/32945/1
diff --git a/src/drivers/aspeed/ast2050/ast2050.c b/src/drivers/aspeed/ast2050/ast2050.c index 631372d..21af5c7 100644 --- a/src/drivers/aspeed/ast2050/ast2050.c +++ b/src/drivers/aspeed/ast2050/ast2050.c @@ -37,13 +37,12 @@
static void aspeed_ast2050_init(struct device *dev) { - u8 ret; struct drm_device drm_dev;
drm_dev.pdev = dev;
printk(BIOS_INFO, "ASpeed AST2050: initializing video device\n"); - ret = ast_driver_load(&drm_dev, 0); + ast_driver_load(&drm_dev, 0);
/* Unlock extended configuration registers */ outb(0x80, 0x3d4); outb(0xa8, 0x3d5);
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32945 )
Change subject: drivers/aspeed/ast2050: Remove variable set but not used ......................................................................
Patch Set 1: Code-Review+1
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32945 )
Change subject: drivers/aspeed/ast2050: Remove variable set but not used ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32945 )
Change subject: drivers/aspeed/ast2050: Remove variable set but not used ......................................................................
drivers/aspeed/ast2050: Remove variable set but not used
Change-Id: Iedda92edf8c4eb7be037dcc0faa6fe8aa0c0754c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/32945 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/drivers/aspeed/ast2050/ast2050.c 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/drivers/aspeed/ast2050/ast2050.c b/src/drivers/aspeed/ast2050/ast2050.c index 631372d..21af5c7 100644 --- a/src/drivers/aspeed/ast2050/ast2050.c +++ b/src/drivers/aspeed/ast2050/ast2050.c @@ -37,13 +37,12 @@
static void aspeed_ast2050_init(struct device *dev) { - u8 ret; struct drm_device drm_dev;
drm_dev.pdev = dev;
printk(BIOS_INFO, "ASpeed AST2050: initializing video device\n"); - ret = ast_driver_load(&drm_dev, 0); + ast_driver_load(&drm_dev, 0);
/* Unlock extended configuration registers */ outb(0x80, 0x3d4); outb(0xa8, 0x3d5);
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)