Attention is currently required from: Paul Menzel, Mario Scheithauer, Werner Zeh. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64024 )
Change subject: drivers/phy/m88e1512: Add new driver for Marvell PHY 88E1512 ......................................................................
Patch Set 3:
(2 comments)
File src/drivers/phy/m88e1512/chip.h:
https://review.coreboot.org/c/coreboot/+/64024/comment/2a515a5d_41fed1d1 PS3, Line 4: unsigned char device_index; What does this describe? Something functional? is it related to coreboot devices? or just cosmetic, i.e. what is printed to the log?
File src/soc/intel/elkhartlake/tsn_gbe.c:
https://review.coreboot.org/c/coreboot/+/64024/comment/d16998a8_33803be1 PS1, Line 124: .ops_pci = &pci_dev_ops_pci,
Is mentioned in the commit message: […]
That EHL is a(/the?) corresponding SoC is only visible to people who know what board you are working on. It's not covered by the scope given in the commit summary.
And `pci_dev_ops_pci` seems to be about subsystem IDs. It's not wrong to have it here, but looks like an unrelated bugfix.