Attention is currently required from: Kevin Chang, Paul Menzel, Nick Vaccaro, Derek Huang, YH Lin, Zhuohao Lee. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52495 )
Change subject: mb/google/volteer/variant/lindar: Create dynamic fan table mechanism ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/mainboard/google/volteer/variants/lindar/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/52495/comment/c54edeca_0f3706fb PS4, Line 85: [0] = {.target = DPTF_CPU, : .thresholds = {TEMP_PCT(85, 90), : TEMP_PCT(80, 69), : TEMP_PCT(75, 56), : TEMP_PCT(70, 46), : TEMP_PCT(65, 36),}}, : [1] = {.target = DPTF_TEMP_SENSOR_0, : .thresholds = {TEMP_PCT(50, 90), : TEMP_PCT(47, 69), : TEMP_PCT(45, 56), : TEMP_PCT(42, 46), : TEMP_PCT(39, 36),}}, : [2] = {.target = DPTF_TEMP_SENSOR_1, : .thresholds = {TEMP_PCT(50, 90), : TEMP_PCT(47, 69), : TEMP_PCT(45, 56), : TEMP_PCT(42, 46), : TEMP_PCT(39, 36),}}, : [3] = {.target = DPTF_TEMP_SENSOR_2, : .thresholds = {TEMP_PCT(50, 90), : TEMP_PCT(47, 69), : TEMP_PCT(45, 56), : TEMP_PCT(42, 46), : TEMP_PCT(39, 36),}}, : [4] = {.target = DPTF_TEMP_SENSOR_3, : .thresholds = {TEMP_PCT(50, 90), : TEMP_PCT(47, 69), : TEMP_PCT(45, 56), : TEMP_PCT(42, 46), : TEMP_PCT(39, 36),}}}" please follow the same formatting as the baseboard