Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.
Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84587?usp=email )
Change subject: soc/amd/*: Explicitly include static.h for config_of_soc ......................................................................
soc/amd/*: Explicitly include static.h for config_of_soc
As per commit 865173153760 ("sconfig: Move config_of_soc from device.h to static.h"), sources that require access to the devicetree should directly include static.h so that it can be removed from device.h, eliminating unnecessary dependencies on static.h for files that only need the types and function declarations in device.h.
Change-Id: I9db5d80ca0a75ccff3b8e24db0ccbd6b36c84dcb Signed-off-by: Nicholas Chin nic.c3.14@gmail.com --- M src/soc/amd/cezanne/acpi.c M src/soc/amd/cezanne/fsp_m_params.c M src/soc/amd/cezanne/root_complex.c M src/soc/amd/glinda/acpi.c M src/soc/amd/glinda/fsp_m_params.c M src/soc/amd/glinda/root_complex.c M src/soc/amd/mendocino/acpi.c M src/soc/amd/mendocino/fsp_m_params.c M src/soc/amd/mendocino/root_complex.c M src/soc/amd/phoenix/acpi.c M src/soc/amd/phoenix/fsp_m_params.c M src/soc/amd/phoenix/root_complex.c M src/soc/amd/picasso/fch.c M src/soc/amd/picasso/fsp_m_params.c M src/soc/amd/picasso/root_complex.c 15 files changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/84587/1
diff --git a/src/soc/amd/cezanne/acpi.c b/src/soc/amd/cezanne/acpi.c index f60512d..4481c46 100644 --- a/src/soc/amd/cezanne/acpi.c +++ b/src/soc/amd/cezanne/acpi.c @@ -15,6 +15,7 @@ #include <cpu/amd/cpuid.h> #include <device/device.h> #include <soc/iomap.h> +#include <static.h> #include <types.h> #include "chip.h"
diff --git a/src/soc/amd/cezanne/fsp_m_params.c b/src/soc/amd/cezanne/fsp_m_params.c index f86be94..5349a16 100644 --- a/src/soc/amd/cezanne/fsp_m_params.c +++ b/src/soc/amd/cezanne/fsp_m_params.c @@ -10,6 +10,7 @@ #include <fsp/api.h> #include <soc/platform_descriptors.h> #include <soc/pci_devs.h> +#include <static.h> #include <string.h> #include <types.h> #include <vendorcode/amd/fsp/cezanne/FspUsb.h> diff --git a/src/soc/amd/cezanne/root_complex.c b/src/soc/amd/cezanne/root_complex.c index 04fb90c..d9999b9 100644 --- a/src/soc/amd/cezanne/root_complex.c +++ b/src/soc/amd/cezanne/root_complex.c @@ -9,6 +9,7 @@ #include <device/device.h> #include <device/pci.h> #include <soc/iomap.h> +#include <static.h> #include <stdint.h> #include "chip.h"
diff --git a/src/soc/amd/glinda/acpi.c b/src/soc/amd/glinda/acpi.c index eb1d478..dbe610c 100644 --- a/src/soc/amd/glinda/acpi.c +++ b/src/soc/amd/glinda/acpi.c @@ -18,6 +18,7 @@ #include <cpu/amd/cpuid.h> #include <device/device.h> #include <soc/iomap.h> +#include <static.h> #include <types.h> #include "chip.h"
diff --git a/src/soc/amd/glinda/fsp_m_params.c b/src/soc/amd/glinda/fsp_m_params.c index 843a2d9..1d297d4 100644 --- a/src/soc/amd/glinda/fsp_m_params.c +++ b/src/soc/amd/glinda/fsp_m_params.c @@ -13,6 +13,7 @@ #include <fsp/api.h> #include <soc/platform_descriptors.h> #include <soc/pci_devs.h> +#include <static.h> #include <string.h> #include <types.h> #include <vendorcode/amd/fsp/glinda/FspUsb.h> diff --git a/src/soc/amd/glinda/root_complex.c b/src/soc/amd/glinda/root_complex.c index 776fc32..953e089 100644 --- a/src/soc/amd/glinda/root_complex.c +++ b/src/soc/amd/glinda/root_complex.c @@ -11,6 +11,7 @@ #include <device/device.h> #include <device/pci.h> #include <soc/iomap.h> +#include <static.h> #include <stdint.h> #include "chip.h"
diff --git a/src/soc/amd/mendocino/acpi.c b/src/soc/amd/mendocino/acpi.c index e7f0d96..9982d84 100644 --- a/src/soc/amd/mendocino/acpi.c +++ b/src/soc/amd/mendocino/acpi.c @@ -17,6 +17,7 @@ #include <cpu/amd/cpuid.h> #include <device/device.h> #include <soc/iomap.h> +#include <static.h> #include <types.h> #include "chip.h"
diff --git a/src/soc/amd/mendocino/fsp_m_params.c b/src/soc/amd/mendocino/fsp_m_params.c index 6582a7c..8a76669 100644 --- a/src/soc/amd/mendocino/fsp_m_params.c +++ b/src/soc/amd/mendocino/fsp_m_params.c @@ -12,6 +12,7 @@ #include <fsp/api.h> #include <soc/platform_descriptors.h> #include <soc/pci_devs.h> +#include <static.h> #include <string.h> #include <types.h> #include <vendorcode/amd/fsp/mendocino/FspUsb.h> diff --git a/src/soc/amd/mendocino/root_complex.c b/src/soc/amd/mendocino/root_complex.c index a7cbe51..65ae507 100644 --- a/src/soc/amd/mendocino/root_complex.c +++ b/src/soc/amd/mendocino/root_complex.c @@ -12,6 +12,7 @@ #include <device/pci.h> #include <fsp/amd_misc_data.h> #include <soc/iomap.h> +#include <static.h> #include <stdint.h> #include "chip.h"
diff --git a/src/soc/amd/phoenix/acpi.c b/src/soc/amd/phoenix/acpi.c index c6e06be..a182dfbb 100644 --- a/src/soc/amd/phoenix/acpi.c +++ b/src/soc/amd/phoenix/acpi.c @@ -18,6 +18,7 @@ #include <cpu/amd/cpuid.h> #include <device/device.h> #include <soc/iomap.h> +#include <static.h> #include <types.h> #include <vendorcode/amd/opensil/opensil.h> #include "chip.h" diff --git a/src/soc/amd/phoenix/fsp_m_params.c b/src/soc/amd/phoenix/fsp_m_params.c index 06c7127..45a038e 100644 --- a/src/soc/amd/phoenix/fsp_m_params.c +++ b/src/soc/amd/phoenix/fsp_m_params.c @@ -13,6 +13,7 @@ #include <fsp/api.h> #include <soc/platform_descriptors.h> #include <soc/pci_devs.h> +#include <static.h> #include <string.h> #include <types.h> #include <vendorcode/amd/fsp/phoenix/FspUsb.h> diff --git a/src/soc/amd/phoenix/root_complex.c b/src/soc/amd/phoenix/root_complex.c index 7fed3bd..724121c 100644 --- a/src/soc/amd/phoenix/root_complex.c +++ b/src/soc/amd/phoenix/root_complex.c @@ -11,6 +11,7 @@ #include <device/device.h> #include <device/pci.h> #include <soc/iomap.h> +#include <static.h> #include <stdint.h> #include "chip.h"
diff --git a/src/soc/amd/picasso/fch.c b/src/soc/amd/picasso/fch.c index 8952c16..3550349 100644 --- a/src/soc/amd/picasso/fch.c +++ b/src/soc/amd/picasso/fch.c @@ -21,6 +21,7 @@ #include <soc/smi.h> #include <soc/amd_pci_int_defs.h> #include <soc/pci_devs.h> +#include <static.h> #include <types.h> #include "chip.h"
diff --git a/src/soc/amd/picasso/fsp_m_params.c b/src/soc/amd/picasso/fsp_m_params.c index 0be815e..d1280fd 100644 --- a/src/soc/amd/picasso/fsp_m_params.c +++ b/src/soc/amd/picasso/fsp_m_params.c @@ -8,6 +8,7 @@ #include <soc/platform_descriptors.h> #include <soc/pci_devs.h> #include <soc/fsp.h> +#include <static.h> #include <types.h> #include "chip.h"
diff --git a/src/soc/amd/picasso/root_complex.c b/src/soc/amd/picasso/root_complex.c index a3bd729..aa75f0b 100644 --- a/src/soc/amd/picasso/root_complex.c +++ b/src/soc/amd/picasso/root_complex.c @@ -8,6 +8,7 @@ #include <arch/ioapic.h> #include <device/device.h> #include <device/pci.h> +#include <static.h> #include <stdint.h> #include <soc/iomap.h> #include "chip.h"