HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41487 )
Change subject: mb/google/foster: Remove unused 'include <memrange.h> ......................................................................
mb/google/foster: Remove unused 'include <memrange.h>
Change-Id: Ic26d03d0e695ce0823332d4c6430186c7bfbeac1 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/foster/mainboard.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/41487/1
diff --git a/src/mainboard/google/foster/mainboard.c b/src/mainboard/google/foster/mainboard.c index f18e95a..4a56e8a 100644 --- a/src/mainboard/google/foster/mainboard.c +++ b/src/mainboard/google/foster/mainboard.c @@ -2,7 +2,6 @@
#include <arch/mmu.h> #include <device/device.h> -#include <memrange.h> #include <soc/addressmap.h> #include <soc/clk_rst.h> #include <soc/clock.h>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41487
to look at the new patch set (#2).
Change subject: mb/google/foster: Remove unused 'include <memrange.h>' ......................................................................
mb/google/foster: Remove unused 'include <memrange.h>'
Change-Id: Ic26d03d0e695ce0823332d4c6430186c7bfbeac1 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/foster/mainboard.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/41487/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41487
to look at the new patch set (#3).
Change subject: mb/google/foster: Remove unused 'include <memrange.h> ......................................................................
mb/google/foster: Remove unused 'include <memrange.h>
Change-Id: Ic26d03d0e695ce0823332d4c6430186c7bfbeac1 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/foster/mainboard.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/41487/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41487 )
Change subject: mb/google/foster: Remove unused 'include <memrange.h> ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41487 )
Change subject: mb/google/foster: Remove unused 'include <memrange.h> ......................................................................
mb/google/foster: Remove unused 'include <memrange.h>
Change-Id: Ic26d03d0e695ce0823332d4c6430186c7bfbeac1 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/41487 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/foster/mainboard.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/foster/mainboard.c b/src/mainboard/google/foster/mainboard.c index f18e95a..4a56e8a 100644 --- a/src/mainboard/google/foster/mainboard.c +++ b/src/mainboard/google/foster/mainboard.c @@ -2,7 +2,6 @@
#include <arch/mmu.h> #include <device/device.h> -#include <memrange.h> #include <soc/addressmap.h> #include <soc/clk_rst.h> #include <soc/clock.h>
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41487 )
Change subject: mb/google/foster: Remove unused 'include <memrange.h> ......................................................................
Patch Set 6:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4039 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4038 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4037 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4036
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)