[M] Change in coreboot[master]: util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards

[Mike Banon (Code Review)]

Attention is currently required from: Balázs Vinarz, HacX Scedix, Kyösti Mälkki, Martin L Roth, Paul Menzel, Vlado Ilic, [e-mail].

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76832?usp=email )

Change subject: util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards
......................................................................

Patch Set 1:

(3 comments)

Patchset:

PS1:
> Okay, I walked through it. […]

- LEGACY_SMP_INIT is a part of the common code, i.e.

./src/cpu/x86/lapic/Makefile.inc:2:ramstage-$(CONFIG_LEGACY_SMP_INIT) += lapic_cpu_init.c
./src/cpu/x86/lapic/Makefile.inc:3:ramstage-$(CONFIG_LEGACY_SMP_INIT) += secondary.S

- I had to restore LEGACY_SMP_INIT because the AGESA boards select this config:

./src/northbridge/amd/agesa/family14/Kconfig:5: select LEGACY_SMP_INIT
./src/northbridge/amd/agesa/family15tn/Kconfig:5: select LEGACY_SMP_INIT
./src/northbridge/amd/agesa/family16kb/Kconfig:5: select LEGACY_SMP_INIT

PS1:
> There were no voluntary reviewer resources to complete the plaform cleanups while the boards were st […]

Atm I can only volunteer with testing _(and I took this "git revert" quest above for my ~1 week spare window only because the success was guaranteed during this limited time)_ - that testing help will be available since the end of August when I'll return to my hardware. But since the unbricking is easy & quick and I have this FT232H-based "corelogs" adapter - http://dangerousprototypes.com/docs/Corelogs_adapter - I will be able to help greatly! _P.S. Will repost this reply to April 25th thread_

PS1: 
Replies to Balázs and Kyösti