Attention is currently required from: Hung-Te Lin, Paul Menzel, Angel Pons, Yu-Ping Wu.
Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56794 )
Change subject: libpayload/pci: Add PCIe interfaces for MediaTek platform
......................................................................
Patch Set 42:
(1 comment)
File payloads/libpayload/drivers/pcie_mediatek.c:
https://review.coreboot.org/c/coreboot/+/56794/comment/21fad88d_8447d5f7
PS38, Line 22: pcie_base = base;
The base address can be stored in the coreboot table. […]
I think maybe we can use the config data from device tree so that we don't need to add macros to define it. I'll try to create a similar patch, thanks for the information.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56794
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ea7d111fed6b816fa2352fe93c268116519a577
Gerrit-Change-Number: 56794
Gerrit-PatchSet: 42
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 30 Mar 2022 08:00:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment