Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40475 )
Change subject: device: Add checks for NULL in device_const.c functions
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40475/3/src/device/device_const.c
File src/device/device_const.c:
https://review.coreboot.org/c/coreboot/+/40475/3/src/device/device_const.c@8...
PS3, Line 89: if (!path1 || !path2)
I'd split the checks so that one can tell whether the null comes from path1 or path2: […]
I changed it to add assert and get rid of the individual print messages.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40475
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ad8d2bcb9d0546104c5e065af1eeff331cdf96d
Gerrit-Change-Number: 40475
Gerrit-PatchSet: 5
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sun, 19 Apr 2020 19:10:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment