HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38271 )
Change subject: include/commonlib: Fix typos ......................................................................
include/commonlib: Fix typos
Change-Id: I9650084f42de15c04c7e26d8a4442a4f9ff65a87 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/commonlib/include/commonlib/region.h 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/38271/1
diff --git a/src/commonlib/include/commonlib/region.h b/src/commonlib/include/commonlib/region.h index 39db1bb..47df9b6 100644 --- a/src/commonlib/include/commonlib/region.h +++ b/src/commonlib/include/commonlib/region.h @@ -31,7 +31,7 @@ struct region_device;
/* - * Returns NULL on error otherwise a buffer is returned with the conents of + * Returns NULL on error otherwise a buffer is returned with the contents of * the requested data at offset of size. */ void *rdev_mmap(const struct region_device *rd, size_t offset, size_t size); @@ -173,7 +173,7 @@ struct region_device rdev; };
-/* Inititalize at runtime a mem_region_device. This would be used when +/* Initialize at runtime a mem_region_device. This would be used when * the base and size are dynamic or can't be known during linking. * There are two variants: read-only and read-write. */ void mem_region_device_ro_init(struct mem_region_device *mdev, void *base,
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38271 )
Change subject: include/commonlib: Fix typos ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38271 )
Change subject: include/commonlib: Fix typos ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38271 )
Change subject: include/commonlib: Fix typos ......................................................................
Patch Set 1: Code-Review+1
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38271 )
Change subject: include/commonlib: Fix typos ......................................................................
include/commonlib: Fix typos
Change-Id: I9650084f42de15c04c7e26d8a4442a4f9ff65a87 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/38271 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/commonlib/include/commonlib/region.h 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/commonlib/include/commonlib/region.h b/src/commonlib/include/commonlib/region.h index 39db1bb..47df9b6 100644 --- a/src/commonlib/include/commonlib/region.h +++ b/src/commonlib/include/commonlib/region.h @@ -31,7 +31,7 @@ struct region_device;
/* - * Returns NULL on error otherwise a buffer is returned with the conents of + * Returns NULL on error otherwise a buffer is returned with the contents of * the requested data at offset of size. */ void *rdev_mmap(const struct region_device *rd, size_t offset, size_t size); @@ -173,7 +173,7 @@ struct region_device rdev; };
-/* Inititalize at runtime a mem_region_device. This would be used when +/* Initialize at runtime a mem_region_device. This would be used when * the base and size are dynamic or can't be known during linking. * There are two variants: read-only and read-write. */ void mem_region_device_ro_init(struct mem_region_device *mdev, void *base,
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Kyösti Mälkki (Code Review)
-
Nico Huber (Code Review)
-
Paul Menzel (Code Review)