HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38269 )
Change subject: src/commonlib/storage: Fix typos ......................................................................
src/commonlib/storage: Fix typos
Change-Id: Ie210191b79e94d3918ea95d40aeba40f33eb1b2f Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/commonlib/storage/mmc.c M src/commonlib/storage/sd_mmc.c M src/commonlib/storage/sdhci.c 3 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/38269/1
diff --git a/src/commonlib/storage/mmc.c b/src/commonlib/storage/mmc.c index 1e0f7d2..8eaa2ee 100644 --- a/src/commonlib/storage/mmc.c +++ b/src/commonlib/storage/mmc.c @@ -436,7 +436,7 @@ if ((capacity >> 20) > 2 * 1024) media->capacity[MMC_PARTITION_USER] = capacity;
- /* Determine the boot parition sizes */ + /* Determine the boot partition sizes */ hc_erase_size = ext_csd[224] * 512 * KiB; capacity = ext_csd[EXT_CSD_BOOT_SIZE_MULT] * 128 * KiB; media->capacity[MMC_PARTITION_BOOT_1] = capacity; diff --git a/src/commonlib/storage/sd_mmc.c b/src/commonlib/storage/sd_mmc.c index ae15656..c5fa76c 100644 --- a/src/commonlib/storage/sd_mmc.c +++ b/src/commonlib/storage/sd_mmc.c @@ -199,7 +199,7 @@
/* * For MMC cards, set the Relative Address. - * For SD cards, get the Relatvie Address. + * For SD cards, get the Relative Address. * This also puts the cards into Standby State */ cmd.cmdidx = SD_CMD_SEND_RELATIVE_ADDR; diff --git a/src/commonlib/storage/sdhci.c b/src/commonlib/storage/sdhci.c index 6d99508..7d48265 100644 --- a/src/commonlib/storage/sdhci.c +++ b/src/commonlib/storage/sdhci.c @@ -146,7 +146,7 @@ sdhci_writel(sdhci_ctrlr, SDHCI_INT_ALL_MASK, SDHCI_INT_STATUS); mask = SDHCI_CMD_INHIBIT | SDHCI_DATA_INHIBIT;
- /* We shouldn't wait for data inihibit for stop commands, even + /* We shouldn't wait for data inhibit for stop commands, even though they might use busy signaling */ if (cmd->flags & CMD_FLAG_IGNORE_INHIBIT) mask &= ~SDHCI_DATA_INHIBIT; @@ -324,7 +324,7 @@
/* * on some platform(like rk3399 etc) need to worry about - * cache coherency, so check the buffer, if not dma + * cache coherence, so check the buffer, if not dma * coherent, use bounce_buffer to do DMA management. */ if (!dma_coherent(buf)) { @@ -408,7 +408,7 @@ & SDHCI_CLOCK_INT_STABLE)) { if (timeout == 0) { sdhc_error( - "Internal clock never stabilised.\n"); + "Internal clock never stabilized.\n"); return -1; } timeout--;
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38269 )
Change subject: src/commonlib/storage: Fix typos ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38269 )
Change subject: src/commonlib/storage: Fix typos ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Other than two exceptions, the rest are indeed typos
https://review.coreboot.org/c/coreboot/+/38269/1/src/commonlib/storage/sdhci... File src/commonlib/storage/sdhci.c:
https://review.coreboot.org/c/coreboot/+/38269/1/src/commonlib/storage/sdhci... PS1, Line 327: coherency This one isn't a typo: https://en.wiktionary.org/wiki/coherency
https://review.coreboot.org/c/coreboot/+/38269/1/src/commonlib/storage/sdhci... PS1, Line 411: stabilised This is the British English spelling
Hello Kyösti Mälkki, Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38269
to look at the new patch set (#2).
Change subject: src/commonlib/storage: Fix typos ......................................................................
src/commonlib/storage: Fix typos
Change-Id: Ie210191b79e94d3918ea95d40aeba40f33eb1b2f Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/commonlib/storage/mmc.c M src/commonlib/storage/sd_mmc.c M src/commonlib/storage/sdhci.c 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/38269/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38269 )
Change subject: src/commonlib/storage: Fix typos ......................................................................
Patch Set 2:
(2 comments)
Thx
https://review.coreboot.org/c/coreboot/+/38269/1/src/commonlib/storage/sdhci... File src/commonlib/storage/sdhci.c:
https://review.coreboot.org/c/coreboot/+/38269/1/src/commonlib/storage/sdhci... PS1, Line 327: coherency
This one isn't a typo: https://en.wiktionary. […]
Done
https://review.coreboot.org/c/coreboot/+/38269/1/src/commonlib/storage/sdhci... PS1, Line 411: stabilised
This is the British English spelling
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38269 )
Change subject: src/commonlib/storage: Fix typos ......................................................................
Patch Set 2: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38269 )
Change subject: src/commonlib/storage: Fix typos ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38269 )
Change subject: src/commonlib/storage: Fix typos ......................................................................
src/commonlib/storage: Fix typos
Change-Id: Ie210191b79e94d3918ea95d40aeba40f33eb1b2f Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/38269 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/commonlib/storage/mmc.c M src/commonlib/storage/sd_mmc.c M src/commonlib/storage/sdhci.c 3 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/commonlib/storage/mmc.c b/src/commonlib/storage/mmc.c index 1e0f7d2..8eaa2ee 100644 --- a/src/commonlib/storage/mmc.c +++ b/src/commonlib/storage/mmc.c @@ -436,7 +436,7 @@ if ((capacity >> 20) > 2 * 1024) media->capacity[MMC_PARTITION_USER] = capacity;
- /* Determine the boot parition sizes */ + /* Determine the boot partition sizes */ hc_erase_size = ext_csd[224] * 512 * KiB; capacity = ext_csd[EXT_CSD_BOOT_SIZE_MULT] * 128 * KiB; media->capacity[MMC_PARTITION_BOOT_1] = capacity; diff --git a/src/commonlib/storage/sd_mmc.c b/src/commonlib/storage/sd_mmc.c index ae15656..c5fa76c 100644 --- a/src/commonlib/storage/sd_mmc.c +++ b/src/commonlib/storage/sd_mmc.c @@ -199,7 +199,7 @@
/* * For MMC cards, set the Relative Address. - * For SD cards, get the Relatvie Address. + * For SD cards, get the Relative Address. * This also puts the cards into Standby State */ cmd.cmdidx = SD_CMD_SEND_RELATIVE_ADDR; diff --git a/src/commonlib/storage/sdhci.c b/src/commonlib/storage/sdhci.c index 6d99508..fd9fc63 100644 --- a/src/commonlib/storage/sdhci.c +++ b/src/commonlib/storage/sdhci.c @@ -146,7 +146,7 @@ sdhci_writel(sdhci_ctrlr, SDHCI_INT_ALL_MASK, SDHCI_INT_STATUS); mask = SDHCI_CMD_INHIBIT | SDHCI_DATA_INHIBIT;
- /* We shouldn't wait for data inihibit for stop commands, even + /* We shouldn't wait for data inhibit for stop commands, even though they might use busy signaling */ if (cmd->flags & CMD_FLAG_IGNORE_INHIBIT) mask &= ~SDHCI_DATA_INHIBIT;