Change in coreboot[master]: soc/intel/common/block: Move smihandler common functions into common ...

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26138 )

Change subject: soc/intel/common/block: Move smihandler common functions into common code
......................................................................

Patch Set 42:

(3 comments)

https://review.coreboot.org/c/coreboot/+/26138/41/src/soc/intel/common/block... 
File src/soc/intel/common/block/smm/smihandler.c:

https://review.coreboot.org/c/coreboot/+/26138/41/src/soc/intel/common/block... 
PS41, Line 67: __weak
Why is this still kept weak? None of the SoCs provide their own implementation after this change.

https://review.coreboot.org/c/coreboot/+/26138/41/src/soc/intel/common/block... 
PS41, Line 70: tco_sts
So, there is a slight change in behavior now for APL. Previously, this function would do nothing, but now:
a) It checks bit 8 in tco_sts, but that bit is marked reserved. As per EDS, it is RO and reads as 0, so I am guessing this has no side-effects?
b) But, CONFIG(SPI_FLASH_SMM) could be true and so now this would always end up calling fast_spi_enable_wp(). Are you changing this intentionally?

https://review.coreboot.org/c/coreboot/+/26138/41/src/soc/intel/common/block... 
PS41, Line 499: 
nit: extra blank line not required.