Attention is currently required from: Anil Kumar K, Bora Guvendik, Hannah Williams, Paul Menzel, Subrata Banik.
Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84103?usp=email )
Change subject: soc/intel/common/block/acpi: Add GPE1 blocks to ACPI FADT table
......................................................................
Patch Set 9:
(3 comments)
File src/soc/intel/common/block/acpi/Kconfig:
https://review.coreboot.org/c/coreboot/+/84103/comment/3d637eb2_3dfc0da9?usp... :
PS9, Line 83: Requires define GPE1_STS(0) and GPE1_REG_MAX from the SOC header.
Please add a blank line above.
not sure if we can have a bank line under 'help'. But let me re-arrange the desciption.
https://review.coreboot.org/c/coreboot/+/84103/comment/a67b8e46_795704a8?usp... :
PS9, Line 89: for
to
Done
https://review.coreboot.org/c/coreboot/+/84103/comment/3e402da5_9e89568a?usp... :
PS9, Line 90: that publishes
… that publish … or … publishing …
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84103?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia6928c35b86f4a2243d58597b17b2a3a5f54271e
Gerrit-Change-Number: 84103
Gerrit-PatchSet: 9
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Sat, 31 Aug 2024 07:23:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org