Change in ...coreboot[master]: soc/intel/braswell/Makefile.inc: Remove cpu_microcode_bins
Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32510
Change subject: soc/intel/braswell/Makefile.inc: Remove cpu_microcode_bins ......................................................................
soc/intel/braswell/Makefile.inc: Remove cpu_microcode_bins
cpu_microcode_bins is comment out. Remove this line.
BUG=NA TEST=Portwell PQ7-M107
Change-Id: Ic398d232bea84a765fce940ef876916a873e561f Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/soc/intel/braswell/Makefile.inc 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/32510/1
diff --git a/src/soc/intel/braswell/Makefile.inc b/src/soc/intel/braswell/Makefile.inc index a538f7d..9567eb3 100644 --- a/src/soc/intel/braswell/Makefile.inc +++ b/src/soc/intel/braswell/Makefile.inc @@ -52,8 +52,6 @@ smm-y += spi.c smm-y += tsc_freq.c
-# cpu_microcode_bins += ??? - CPPFLAGS_common += -I$(src)/soc/intel/braswell/ CPPFLAGS_common += -I$(src)/soc/intel/braswell/include CPPFLAGS_common += -I$(src)/vendorcode/intel/fsp/fsp1_1/braswell
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32510 )
Change subject: soc/intel/braswell/Makefile.inc: Remove cpu_microcode_bins ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32510/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32510/1//COMMIT_MSG@7 PS1, Line 7: Remove cpu_microcode_bins not obvious from the subject line that you're simply removing commented out code. Something like "Remove commented-out line" would be more clear that the change is a no-op
Hello Patrick Rudolph, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32510
to look at the new patch set (#2).
Change subject: soc/intel/braswell/Makefile.inc: Remove commented-out line ......................................................................
soc/intel/braswell/Makefile.inc: Remove commented-out line
cpu_microcode_bins is comment out. Remove this line.
BUG=NA TEST=Portwell PQ7-M107
Change-Id: Ic398d232bea84a765fce940ef876916a873e561f Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/soc/intel/braswell/Makefile.inc 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/32510/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32510 )
Change subject: soc/intel/braswell/Makefile.inc: Remove commented-out line ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/32510/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32510/2//COMMIT_MSG@9 PS2, Line 9: comment commented
Hello Patrick Rudolph, Angel Pons, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32510
to look at the new patch set (#3).
Change subject: soc/intel/braswell/Makefile.inc: Remove commented-out line ......................................................................
soc/intel/braswell/Makefile.inc: Remove commented-out line
cpu_microcode_bins is commented out. Remove this line.
BUG=NA TEST=Portwell PQ7-M107
Change-Id: Ic398d232bea84a765fce940ef876916a873e561f Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/soc/intel/braswell/Makefile.inc 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/32510/3
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32510 )
Change subject: soc/intel/braswell/Makefile.inc: Remove commented-out line ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32510/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32510/2//COMMIT_MSG@9 PS2, Line 9: comment
commented
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32510 )
Change subject: soc/intel/braswell/Makefile.inc: Remove commented-out line ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32510 )
Change subject: soc/intel/braswell/Makefile.inc: Remove commented-out line ......................................................................
soc/intel/braswell/Makefile.inc: Remove commented-out line
cpu_microcode_bins is commented out. Remove this line.
BUG=NA TEST=Portwell PQ7-M107
Change-Id: Ic398d232bea84a765fce940ef876916a873e561f Signed-off-by: Frans Hendriks fhendriks@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32510 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/braswell/Makefile.inc 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/braswell/Makefile.inc b/src/soc/intel/braswell/Makefile.inc index a7ed4c5..a2b7ee5 100644 --- a/src/soc/intel/braswell/Makefile.inc +++ b/src/soc/intel/braswell/Makefile.inc @@ -52,8 +52,6 @@ smm-y += spi.c smm-y += tsc_freq.c
-# cpu_microcode_bins += ??? - CPPFLAGS_common += -I$(src)/soc/intel/braswell/ CPPFLAGS_common += -I$(src)/soc/intel/braswell/include CPPFLAGS_common += -I$(call strip_quotes,$(CONFIG_FSP_HEADER_PATH))
-
Angel Pons (Code Review) -
Frans Hendriks (Code Review)
-
Matt DeVillier (Code Review)
-
Patrick Georgi (Code Review)