Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32510 )
Change subject: soc/intel/braswell/Makefile.inc: Remove cpu_microcode_bins
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32510/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32510/1//COMMIT_MSG@7
PS1, Line 7: Remove cpu_microcode_bins
not obvious from the subject line that you're simply removing commented out code. Something like "Remove commented-out line" would be more clear that the change is a no-op
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32510
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic398d232bea84a765fce940ef876916a873e561f
Gerrit-Change-Number: 32510
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Wed, 01 May 2019 00:48:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment