Attention is currently required from: Hung-Te Lin, Yu-Ping Wu, Yidi Lin.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53894 )
Change subject: soc/mediatek/mt8195: Add i2c driver support
......................................................................
Patch Set 2:
(1 comment)
File src/soc/mediatek/mt8195/i2c.c:
https://review.coreboot.org/c/coreboot/+/53894/comment/028b4a93_dfb6e4ef
PS1, Line 13: #define I2C_FS_START_CON 0x0
One blank line after this.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/53894
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia26e55512501e9758d7f5543d176730cf30ce03d
Gerrit-Change-Number: 53894
Gerrit-PatchSet: 2
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Comment-Date: Fri, 07 May 2021 08:04:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment