[S] Change in coreboot[master]: mb/google/rex/variants/baseboard/rex: Add CPU power limit values - coreboot-gerrit

22 May 2023


      Attention is currently required from: Tarun Tuli, Kapil Porwal, Sumeet R Pawnikar.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74754 )
Change subject: mb/google/rex/variants/baseboard/rex: Add CPU power limit values
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/google/rex/variants/baseboard/rex/ramstage.c:
https://review.coreboot.org/c/coreboot/+/74754/comment/12e1dd19_83e67397 
PS8, Line 8: 	/*
           : 	 * SKU_ID, TDP (Watts), pl1_min (milliWatts), pl1_max (milliWatts),
           : 	 * pl2_min (milliWatts), pl2_max (milliWatts), pl4 (milliWatts)
           : 	 * Following values are for performance config as per document #640982
           : 	 */
can we move this above line#7?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74754
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If46445157358e3e0f227e26a35b4303fc9189a4b
Gerrit-Change-Number: 74754
Gerrit-PatchSet: 8
Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Mon, 22 May 2023 07:15:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment