Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80083?usp=email )
Change subject: soc/amd: factor out non-CAR romstage to common code
......................................................................
Patch Set 2:
(2 comments)
File src/soc/amd/common/block/acpimmio/Kconfig:
https://review.coreboot.org/c/coreboot/+/80083/comment/222ef2d1_f8c77f75 :
PS2, Line 21: config SOC_AMD_COMMON_ROMSTAGE_LEGACY_DMA_FIXUP
Put this in the soc/amd/common/block/cpu Kconfig?
File src/soc/amd/common/block/cpu/noncar/romstage.c:
https://review.coreboot.org/c/coreboot/+/80083/comment/657bcc12_563683bc :
PS2, Line 32: Fixup
Nit: This should just be 'fix' or two words, 'fix up'. A 'fixup' is a noun (if you can even count it as a real word - it's not in the dictionary), 'fix' or 'fix up' is the verb. This is similar to 'set up', a verb, vs 'setup', a noun. Fix it up if you want, or not. Up to you. :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80083?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a0695714ba08b13a58b12a490da50cb7f5a1ca9
Gerrit-Change-Number: 80083
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 18 Jan 2024 22:17:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment