Attention is currently required from: Martin Roth, Rob Barnes.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56667 )
Change subject: guybrush: Document USB mapping in devicetree
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/56667/comment/56986be1_94480d88
PS2, Line 222: register "desc" = ""Right Type-C Port""
Should this actually be Left Type-C port / C0?
You are right. This should be corrected. Also the same for Right Type-A/Type-C ports.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56667
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14cbb6af021bb27c89aa82456722f21aa09617be
Gerrit-Change-Number: 56667
Gerrit-PatchSet: 3
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Comment-Date: Thu, 29 Jul 2021 23:28:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment