Change in coreboot[master]: mb/supermicro/x11-lga1151-series: switch from dev.init to mb_ops.init

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48083 )

Change subject: mb/supermicro/x11-lga1151-series: switch from dev.init to mb_ops.init
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48083/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/48083/5//COMMIT_MSG@9 
PS5, Line 9: Set mainboard_ops.init directly instead of using the indirection via a
           : mainboard_enable function.
> Yeah, I was confused by the names.
>
> I had a look at how google boards do it. Some use mainboard chip init, others mainboard dev init, so there shouldn't be a problem, since it's only PCRs

Yes, it looks like the tree is inconsistent about this. Can you also motivate why it needs to happen earlier?

I think having two different functions named init is confusing, so if anyone want to add some form of mainboard init that requires devices to be enumarated, which is generally the case for ramstage hardware init, he would be in trouble. So I'd recommend keeping this in the device_operations init even if it is not strictly needed for pcr stuff.