Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35071 )
Change subject: mb/asrock/h110m: disable unused sata ports ......................................................................
mb/asrock/h110m: disable unused sata ports
Change-Id: I5b3ad372f1d6607cc7b4a78e3c59d2a5ae1d2cf5 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/asrock/h110m/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/35071/1
diff --git a/src/mainboard/asrock/h110m/devicetree.cb b/src/mainboard/asrock/h110m/devicetree.cb index f87ca45..24409a1 100644 --- a/src/mainboard/asrock/h110m/devicetree.cb +++ b/src/mainboard/asrock/h110m/devicetree.cb @@ -184,8 +184,8 @@ [3] = 1, \ [4] = 1, \ [5] = 1, \ - [6] = 1, \ - [7] = 1, \ + [6] = 0, \ + [7] = 0, \ }"
# PCH UART, SPI, I2C
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35071 )
Change subject: mb/asrock/h110m: disable unused sata ports ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/35071/2/src/mainboard/asrock/h110m/... File src/mainboard/asrock/h110m/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35071/2/src/mainboard/asrock/h110m/... PS2, Line 181: [0] = 1, \ : [1] = 1, \ : [2] = 1, \ : [3] = 1, \ : [4] = 1, \ : [5] = 1, \ The board only has four SATA ports... I think you have two other unused ports.
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35071
to look at the new patch set (#3).
Change subject: mb/asrock/h110m: disable unused sata ports ......................................................................
mb/asrock/h110m: disable unused sata ports
Sets all unused sata ports to disable in the device tree
Note: [*] SATA4 and SATA5 are located at the bottom of the board, but there is no connector for this. Apparently, a board with an increased number of ports is very rare. Perhaps this is a separate variant of the Asrock motherboard. For this reason, these ports are also disabled
Change-Id: I5b3ad372f1d6607cc7b4a78e3c59d2a5ae1d2cf5 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/asrock/h110m/devicetree.cb 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/35071/3
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35071
to look at the new patch set (#4).
Change subject: mb/asrock/h110m: disable unused sata ports ......................................................................
mb/asrock/h110m: disable unused sata ports
Sets all* unused sata ports to disable in the device tree
Note: [*] SATA4 and SATA5 are located at the bottom of the board, but there is no connector for this. Apparently, a board with an increased number of ports is very rare. Perhaps this is a separate variant of the Asrock motherboard. For this reason, these ports are also disabled
Change-Id: I5b3ad372f1d6607cc7b4a78e3c59d2a5ae1d2cf5 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/asrock/h110m/devicetree.cb 1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/35071/4
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35071
to look at the new patch set (#5).
Change subject: mb/asrock/h110m: disable unused sata ports ......................................................................
mb/asrock/h110m: disable unused sata ports
Sets all unused sata ports to disable in the device tree
Note: SATA4 and SATA5 are located at the bottom of the board, but there is no connector for this. Apparently, a board with an increased number of ports is very rare. Perhaps this is a separate variant of the Asrock motherboard. For this reason, these ports are also disabled
Change-Id: I5b3ad372f1d6607cc7b4a78e3c59d2a5ae1d2cf5 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/asrock/h110m/devicetree.cb 1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/35071/5
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35071 )
Change subject: mb/asrock/h110m: disable unused sata ports ......................................................................
Patch Set 8: Code-Review+2
Try rebasing this change to see if it passes the build now
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35071 )
Change subject: mb/asrock/h110m: disable unused sata ports ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35071/2/src/mainboard/asrock/h110m/... File src/mainboard/asrock/h110m/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35071/2/src/mainboard/asrock/h110m/... PS2, Line 181: [0] = 1, \ : [1] = 1, \ : [2] = 1, \ : [3] = 1, \ : [4] = 1, \ : [5] = 1, \
The board only has four SATA ports... I think you have two other unused ports.
SATA4 and SATA5 ports are on the motherboard, but there is no connector for these ports. I disable it and add info about this to the commit message
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35071 )
Change subject: mb/asrock/h110m: disable unused sata ports ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35071/2/src/mainboard/asrock/h110m/... File src/mainboard/asrock/h110m/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35071/2/src/mainboard/asrock/h110m/... PS2, Line 181: [0] = 1, \ : [1] = 1, \ : [2] = 1, \ : [3] = 1, \ : [4] = 1, \ : [5] = 1, \
SATA4 and SATA5 ports are on the motherboard, but there is no connector for these ports. […]
Alright, thank you. I believe the same PCB can be used with other Sunrise Point PCHs which have more SATA ports, hence the missing connector. I have a dead MSI board with the same thing :)
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35071 )
Change subject: mb/asrock/h110m: disable unused sata ports ......................................................................
mb/asrock/h110m: disable unused sata ports
Sets all unused sata ports to disable in the device tree
Note: SATA4 and SATA5 are located at the bottom of the board, but there is no connector for this. Apparently, a board with an increased number of ports is very rare. Perhaps this is a separate variant of the Asrock motherboard. For this reason, these ports are also disabled
Change-Id: I5b3ad372f1d6607cc7b4a78e3c59d2a5ae1d2cf5 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35071 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asrock/h110m/devicetree.cb 1 file changed, 6 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/asrock/h110m/devicetree.cb b/src/mainboard/asrock/h110m/devicetree.cb index 47d534a..1240d39 100644 --- a/src/mainboard/asrock/h110m/devicetree.cb +++ b/src/mainboard/asrock/h110m/devicetree.cb @@ -182,11 +182,13 @@ [1] = 1, \ [2] = 1, \ [3] = 1, \ - [4] = 1, \ - [5] = 1, \ - [6] = 1, \ - [7] = 1, \ + [4] = 0, \ + [5] = 0, \ + [6] = 0, \ + [7] = 0, \ }" + # SATA4 and SATA5 are located in the lower right corner + # of the board, but there is no connector for this
# PCH UART, SPI, I2C register "SerialIoDevMode" = "{ \
-
Angel Pons (Code Review) -
Maxim Polyakov (Code Review)
-
Patrick Georgi (Code Review)