Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30791
Change subject: src/drivers/intel/fsp1_0: Move PLATFORM_USES_FSP1_0 ......................................................................
src/drivers/intel/fsp1_0: Move PLATFORM_USES_FSP1_0
This is a better location.
Change-Id: Ic1c86c26a66c33760484bb6a86e9763c148a7c96 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/cpu/x86/Kconfig M src/drivers/intel/fsp1_0/Kconfig 2 files changed, 9 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/30791/1
diff --git a/src/cpu/x86/Kconfig b/src/cpu/x86/Kconfig index 232fe63..608afd7 100644 --- a/src/cpu/x86/Kconfig +++ b/src/cpu/x86/Kconfig @@ -151,13 +151,6 @@ This option informs the MTRR code to use the RdMem and WrMem fields in the fixed MTRR MSRs.
-config PLATFORM_USES_FSP1_0 - bool - default n - help - Selected for Intel processors/platform combinations that use the - Intel Firmware Support Package (FSP) 1.0 for initialization. - config MIRROR_PAYLOAD_TO_RAM_BEFORE_LOADING def_bool n help diff --git a/src/drivers/intel/fsp1_0/Kconfig b/src/drivers/intel/fsp1_0/Kconfig index c7f6c18..4d1c4df 100644 --- a/src/drivers/intel/fsp1_0/Kconfig +++ b/src/drivers/intel/fsp1_0/Kconfig @@ -13,6 +13,15 @@ ## GNU General Public License for more details. ##
+config PLATFORM_USES_FSP1_0 + bool + default n + select CACHE_MRC_SETTINGS + help + Selected for Intel processors/platform combinations that use the + Intel Firmware Support Package (FSP) 1.0 for initialization. + + if PLATFORM_USES_FSP1_0
comment "Intel FSP"
Hello Patrick Rudolph, Huang Jin, York Yang, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30791
to look at the new patch set (#3).
Change subject: src/drivers/intel/fsp1_0: Move PLATFORM_USES_FSP1_0 ......................................................................
src/drivers/intel/fsp1_0: Move PLATFORM_USES_FSP1_0
This is a better location.
Change-Id: Ic1c86c26a66c33760484bb6a86e9763c148a7c96 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/cpu/x86/Kconfig M src/drivers/intel/fsp1_0/Kconfig 2 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/30791/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30791 )
Change subject: src/drivers/intel/fsp1_0: Move PLATFORM_USES_FSP1_0 ......................................................................
Patch Set 3: Code-Review+2
Hello Patrick Rudolph, Angel Pons, Huang Jin, York Yang, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30791
to look at the new patch set (#4).
Change subject: src/drivers/intel/fsp1_0: Move PLATFORM_USES_FSP1_0 ......................................................................
src/drivers/intel/fsp1_0: Move PLATFORM_USES_FSP1_0
drivers/intel/fsp1_0/Kconfig is a better location than cpu/x86/Kconfig.
Change-Id: Ic1c86c26a66c33760484bb6a86e9763c148a7c96 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/cpu/x86/Kconfig M src/drivers/intel/fsp1_0/Kconfig 2 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/30791/4
Arthur Heymans has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30791 )
Change subject: src/drivers/intel/fsp1_0: Move PLATFORM_USES_FSP1_0 ......................................................................
src/drivers/intel/fsp1_0: Move PLATFORM_USES_FSP1_0
drivers/intel/fsp1_0/Kconfig is a better location than cpu/x86/Kconfig.
Change-Id: Ic1c86c26a66c33760484bb6a86e9763c148a7c96 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/30791 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/cpu/x86/Kconfig M src/drivers/intel/fsp1_0/Kconfig 2 files changed, 7 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/cpu/x86/Kconfig b/src/cpu/x86/Kconfig index 232fe63..608afd7 100644 --- a/src/cpu/x86/Kconfig +++ b/src/cpu/x86/Kconfig @@ -151,13 +151,6 @@ This option informs the MTRR code to use the RdMem and WrMem fields in the fixed MTRR MSRs.
-config PLATFORM_USES_FSP1_0 - bool - default n - help - Selected for Intel processors/platform combinations that use the - Intel Firmware Support Package (FSP) 1.0 for initialization. - config MIRROR_PAYLOAD_TO_RAM_BEFORE_LOADING def_bool n help diff --git a/src/drivers/intel/fsp1_0/Kconfig b/src/drivers/intel/fsp1_0/Kconfig index 4ce528f..361dd5e 100644 --- a/src/drivers/intel/fsp1_0/Kconfig +++ b/src/drivers/intel/fsp1_0/Kconfig @@ -13,6 +13,13 @@ ## GNU General Public License for more details. ##
+config PLATFORM_USES_FSP1_0 + bool + default n + help + Selected for Intel processors/platform combinations that use the + Intel Firmware Support Package (FSP) 1.0 for initialization. + if PLATFORM_USES_FSP1_0
comment "Intel FSP"
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30791 )
Change subject: src/drivers/intel/fsp1_0: Move PLATFORM_USES_FSP1_0 ......................................................................
Patch Set 5: Code-Review+2
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Subrata Banik (Code Review)