Attention is currently required from: Boris Mittelberg, Caveh Jalali, Karthik Ramasubramanian.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86379?usp=email )
Change subject: ec/google/chromeec: Implement early power off support
......................................................................
Patch Set 4:
(1 comment)
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/86379/comment/07b30ec4_48e69b53?usp... :
PS4, Line 1675: void google_chromeec_do_early_poweroff(void)
Just rename this function to `platform_do_early_poweroff()`, it's otherwise unneeded.
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86379?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0c634d69de36fe8bdb6a61c121e321d3626ac3ff
Gerrit-Change-Number: 86379
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Fri, 14 Feb 2025 17:57:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org