Attention is currently required from: Arthur Heymans, Christian Walter, Felix Held, Filip Lewiński, Martin Roth, Matt DeVillier, Michał Kopeć, Michał Żygowski.
Krystian Hebel has posted comments on this change by Filip Lewiński. ( https://review.coreboot.org/c/coreboot/+/82037?usp=email )
Change subject: security/tpm: Add TPM2 NV_ReadPublic command support
......................................................................
Patch Set 16: Code-Review+2
(5 comments)
Patchset:
PS16:
Just some formatting and typos to be fixed.
File src/security/tpm/tss.h:
https://review.coreboot.org/c/coreboot/+/82037/comment/a3560078_321b20c3?usp... :
PS16, Line 34: index
`space_index`?
https://review.coreboot.org/c/coreboot/+/82037/comment/fd280212_7834e51d?usp... :
PS16, Line 35: hte
the
File src/security/tpm/tss/tcg-2.0/tss.c:
https://review.coreboot.org/c/coreboot/+/82037/comment/c5ba664b_3f8e8606?usp... :
PS16, Line 395: struct nv_read_public_response *nvrp_resp)
One more space required to align it with the inside of the bracket.
https://review.coreboot.org/c/coreboot/+/82037/comment/30c606e9_960675f6?usp... :
PS16, Line 423:
Drop this line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82037?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3c032b4f88d445372beebbe354f458a061a63bb9
Gerrit-Change-Number: 82037
Gerrit-PatchSet: 16
Gerrit-Owner: Filip Lewiński
filip.lewinski@3mdeb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Filip Lewiński
filip.lewinski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 12 Feb 2025 16:45:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes