Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Guangjie Song has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84495?usp=email )
Change subject: soc/mediatek/mt8196: Add PLL and clock init support
......................................................................
Patch Set 27:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84495/comment/905b9721_0ef72dad?usp... :
PS26, Line 7: Clock
clock
Done
File src/soc/mediatek/mt8196/pll.c:
https://review.coreboot.org/c/coreboot/+/84495/comment/079f99cc_baa1e849?usp... :
PS13, Line 1196: 30
Agree with Yu-Ping. […]
Done
File src/soc/mediatek/mt8196/pll.c:
https://review.coreboot.org/c/coreboot/+/84495/comment/9c6f79ad_0419d09e?usp... :
PS26, Line 863: (
No need for the extra `()`
Done
https://review.coreboot.org/c/coreboot/+/84495/comment/03ee83f0_0194e401?usp... :
PS26, Line 1176: mmvote_mtcmos_mtcmos_table
`child_idx` is the same as `parent_idx`. […]
it is expected
now we remove the array to save space and initialize the corresponding registers according to the config rules
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84495?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icac99fb210c87c8b7b14af627fbd2f14e4c47240
Gerrit-Change-Number: 84495
Gerrit-PatchSet: 27
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Guangjie Song
guangjie.song@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Thu, 07 Nov 2024 02:28:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Guangjie Song
guangjie.song@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Comment-In-Reply-To: Jarried Lin
jarried.lin@mediatek.com