Attention is currently required from: Aamir Bohra, Boris Mittelberg, Caveh Jalali, Dinesh Gehlot, Eran Mitrani, Eric Lai, Hung-Te Lin, Jakub "Kuba" Czapiga, Jason Nien, Jayvik Desai, Julius Werner, Kapil Porwal, Martin Roth, Nick Vaccaro, Pranava Y N, Subrata Banik, Subrata Banik, Tarun.
Hello Boris Mittelberg, Caveh Jalali, Dinesh Gehlot, Eran Mitrani, Eric Lai, Hung-Te Lin, Jakub "Kuba" Czapiga, Jason Nien, Jayvik Desai, Julius Werner, Kapil Porwal, Martin Roth, Nick Vaccaro, Pranava Y N, Subrata Banik, Tarun, Yidi Lin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86810?usp=email
to look at the new patch set (#12).
Change subject: google/chromeec: Add function to report the SKU ID ......................................................................
google/chromeec: Add function to report the SKU ID
Add implementation of sku_id function that reports the SKU ID information by making use of ChromeOS EC host command. This function can replace redundant sku_id function definitions across boards that rely on ChromeOS EC host command to report the SKU ID information.
The boards that relying on ChromeOS EC host command for SKU information without any board specific quirks can select EC_GOOGLE_CHROMEEC_SKUID to make use of common sku_id function.
BUG=b:396366352 TEST=Verify zork boot log reports the correct the SKU ID information
Change-Id: I958cc88bf316dd2327b6545c5a37e8010e96c5d7 Signed-off-by: Aamir Bohra aamirbohra@google.com --- M src/ec/google/chromeec/Makefile.mk M src/ec/google/chromeec/ec_skuid.c M src/mainboard/google/brox/Kconfig M src/mainboard/google/brya/Kconfig M src/mainboard/google/cherry/Kconfig M src/mainboard/google/corsola/Kconfig M src/mainboard/google/dedede/Kconfig M src/mainboard/google/fatcat/Kconfig M src/mainboard/google/geralt/Kconfig M src/mainboard/google/guybrush/Kconfig M src/mainboard/google/hatch/Kconfig M src/mainboard/google/herobrine/Kconfig M src/mainboard/google/myst/Kconfig M src/mainboard/google/ocelot/Kconfig M src/mainboard/google/octopus/Kconfig M src/mainboard/google/puff/Kconfig M src/mainboard/google/rauru/Kconfig M src/mainboard/google/rex/Kconfig M src/mainboard/google/skyrim/Kconfig M src/mainboard/google/volteer/Kconfig M src/mainboard/google/zork/sku_id.c M src/mainboard/intel/ptlrvp/Kconfig M src/mainboard/intel/shadowmountain/Kconfig 23 files changed, 11 insertions(+), 28 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/86810/12