Attention is currently required from: Arthur Heymans, Felix Held.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76505?usp=email )
Change subject: soc/amd/genoa: Enable PM and cf9 IO early
......................................................................
Patch Set 6:
(1 comment)
File src/soc/amd/genoa/early_fch.c:
https://review.coreboot.org/c/coreboot/+/76505/comment/ccf8c155_a93989ea :
PS2, Line 16: enable_acpimmio_decode_pm04();
not 100% sure about this one; it should either be removed or an additional kconfig option needs to b […]
The Genoa PPR claims that PMIO can still be accessed through the CD6/CD7 mechanism, so I added the Kconfig option to allow for that. Of course, the public PPR doesn't even mention the FCH section. :-/
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76505?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I05990c2aca40d9cf47a9ebdfd269b80b8f60e300
Gerrit-Change-Number: 76505
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 29 Sep 2023 17:08:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment