Timothy Pearson (tpearson@raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11989
-gerrit
commit 5ed2960597ce68d4ac988f3e5e44d35d1f5f5236 Author: Timothy Pearson tpearson@raptorengineeringinc.com Date: Fri Jun 12 19:43:06 2015 -0500
northbridge/amd/amdmct: Fix hang on boot due to invalid array access
Change-Id: I47755caf7d2ff59463c817e739f9cb2ddd367c18 Signed-off-by: Timothy Pearson tpearson@raptorengineeringinc.com --- src/northbridge/amd/amdmct/wrappers/mcti_d.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/northbridge/amd/amdmct/wrappers/mcti_d.c b/src/northbridge/amd/amdmct/wrappers/mcti_d.c index 95d57fc..9196863 100644 --- a/src/northbridge/amd/amdmct/wrappers/mcti_d.c +++ b/src/northbridge/amd/amdmct/wrappers/mcti_d.c @@ -341,7 +341,7 @@ static void mctGet_MaxLoadFreq(struct DCTStatStruc *pDCTstat) #if (CONFIG_DIMM_SUPPORT & 0x000F)==0x0005 /* AMD_FAM10_DDR3 */ uint8_t dimm;
- for (i = 0; i < 15; i = i + 2) { + for (i = 0; i < MAX_DIMMS_SUPPORTED; i = i + 2) { if (pDCTstat->DIMMValid & (1 << i)) ch1_voltage |= pDCTstat->DimmConfiguredVoltage[i]; if (pDCTstat->DIMMValid & (1 << (i + 1))) @@ -351,7 +351,7 @@ static void mctGet_MaxLoadFreq(struct DCTStatStruc *pDCTstat) for (i = 0; i < 2; i++) { sDCTStruct *pDCTData = pDCTstat->C_DCTPtr[i]; highest_rank_count[i] = 0x0; - for (dimm = 0; dimm < 8; dimm++) { + for (dimm = 0; dimm < MAX_DIMMS_SUPPORTED; dimm++) { if (pDCTData->DimmRanks[dimm] > highest_rank_count[i]) highest_rank_count[i] = pDCTData->DimmRanks[dimm]; }