Vijay P Hiremath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37867 )
Change subject: src/ec/google/chromeec: Get Type-C Mux info from EC
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37867/2/src/ec/google/chromeec/ec.c
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/37867/2/src/ec/google/chromeec/ec.c...
PS2, Line 1417: #define PD_CC_DFP_ATTACHED 5
: #define PD_CC_DEBUG_ACC 6
:
how about adding enum pd_cc_states {} from ec_commands.h
https://review.coreboot.org/c/coreboot/+/37867/2/src/ec/google/chromeec/ec.c...
PS2, Line 1434: cmd.cmd_code = EC_CMD_USB_PD_CONTROL;
: cmd.cmd_version = 3;
: cmd.cmd_data_in = &pd_control;
: cmd.cmd_size_in = sizeof(pd_control);
: cmd.cmd_data_out = &resp;
: cmd.cmd_size_out = sizeof(resp);
: cmd.cmd_dev_index = 0;
how about adding common code for all these like in extcon driver?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37867
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96bfb6036f4340ba42a078cfd7ecaae777a3ed00
Gerrit-Change-Number: 37867
Gerrit-PatchSet: 2
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-CC: Vijay P Hiremath
vijay.p.hiremath@intel.com
Gerrit-CC: caveh jalali
caveh@chromium.org
Gerrit-Comment-Date: Thu, 23 Jan 2020 22:17:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment