Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36050 )
Change subject: mb/google/hatch/akemi: Tune I2C bus 1 clock ......................................................................
mb/google/hatch/akemi: Tune I2C bus 1 clock
Tune I2C bus 1 clock and insure it meets I2C spec.
BUG=b:140665478 TEST==flash coreboot to the DUT and measure I2C bus 1 clock frequency less than 400KHz
Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: Id4cdbad4dd9d451763fb536988402d6e6fe3a378 --- M src/mainboard/google/hatch/variants/akemi/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/36050/1
diff --git a/src/mainboard/google/hatch/variants/akemi/overridetree.cb b/src/mainboard/google/hatch/variants/akemi/overridetree.cb index 5ba8531..b58beaa 100644 --- a/src/mainboard/google/hatch/variants/akemi/overridetree.cb +++ b/src/mainboard/google/hatch/variants/akemi/overridetree.cb @@ -35,6 +35,8 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 50, + .fall_time_ns = 15, }, .i2c[1] = { .speed = I2C_SPEED_FAST,
Hello Philip Chen, Tim Wawrzynczak, Shelley Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36050
to look at the new patch set (#2).
Change subject: mb/google/hatch/akemi: Tune I2C bus 1 clock ......................................................................
mb/google/hatch/akemi: Tune I2C bus 1 clock
Tune I2C bus 1 clock and insure it meets I2C spec.
BUG=b:142683257 TEST==flash coreboot to the DUT and measure I2C bus 1 clock frequency less than 400KHz
Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: Id4cdbad4dd9d451763fb536988402d6e6fe3a378 --- M src/mainboard/google/hatch/variants/akemi/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/36050/2
Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36050 )
Change subject: mb/google/hatch/akemi: Tune I2C bus 1 clock ......................................................................
Patch Set 2:
Can you also tune the other I2C buses?
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36050 )
Change subject: mb/google/hatch/akemi: Tune I2C bus 1 clock ......................................................................
Patch Set 2:
Patch Set 2:
Can you also tune the other I2C buses?
Dear Philip, no I can't since other keyart not ready now, like touchpanel. So I can just do it.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36050 )
Change subject: mb/google/hatch/akemi: Tune I2C bus 1 clock ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36050 )
Change subject: mb/google/hatch/akemi: Tune I2C bus 1 clock ......................................................................
mb/google/hatch/akemi: Tune I2C bus 1 clock
Tune I2C bus 1 clock and insure it meets I2C spec.
BUG=b:142683257 TEST==flash coreboot to the DUT and measure I2C bus 1 clock frequency less than 400KHz
Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: Id4cdbad4dd9d451763fb536988402d6e6fe3a378 Reviewed-on: https://review.coreboot.org/c/coreboot/+/36050 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/akemi/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/akemi/overridetree.cb b/src/mainboard/google/hatch/variants/akemi/overridetree.cb index 5ba8531..b58beaa 100644 --- a/src/mainboard/google/hatch/variants/akemi/overridetree.cb +++ b/src/mainboard/google/hatch/variants/akemi/overridetree.cb @@ -35,6 +35,8 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 50, + .fall_time_ns = 15, }, .i2c[1] = { .speed = I2C_SPEED_FAST,
-
Patrick Georgi (Code Review) -
Peichao Li (Code Review)
-
Philip Chen (Code Review)
-
Tim Wawrzynczak (Code Review)