Attention is currently required from: Tim Wawrzynczak, Michael Niewöhner. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59548 )
Change subject: mb: add new board clevo/tgl-u/l140mu ......................................................................
Patch Set 12:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59548/comment/332edfef_13e8fa0d PS12, Line 7: mb: add new board clevo/tgl-u/l140mu Why not our usual scheme? Suggestion: mb/clevo/tgl-u/l140mu: Add new mainboard
File src/mainboard/clevo/tgl-u/Kconfig:
https://review.coreboot.org/c/coreboot/+/59548/comment/8a10c6fa_4de668bf PS12, Line 48: config VGA_BIOS_ID : default "8086,9b41" This is only needed when an option rom is used. It's not the case here, so remove it.
https://review.coreboot.org/c/coreboot/+/59548/comment/b897a4f8_7108780f PS12, Line 51: config TPM_PIRQ : default 0x77 if BOARD_CLEVO_L140MU # GPP_C9_IRQ I would move this to the other options on the top, so that the variant specific options are not scattered over the file too much.
https://review.coreboot.org/c/coreboot/+/59548/comment/343d819a_441effec PS12, Line 57: config VARIANT_DIR : default "l140mu" if BOARD_CLEVO_L140MU Same here.
File src/mainboard/clevo/tgl-u/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/59548/comment/68d0cd1e_00000fc0 PS12, Line 4: bool "L140MU / L141MU / L142MU" What are the differences between these variants?
File src/mainboard/clevo/tgl-u/variants/l140mu/gpio_early.c:
https://review.coreboot.org/c/coreboot/+/59548/comment/8221229e_debc82e6 PS12, Line 10: PAD_NC(GPP_C22, UP_20K), : PA Not needed here. Please remove.
-
Felix Singer (Code Review)