Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38640 )
Change subject: cpu: Allow to configure microcode at pre-defined address
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38640/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38640/6//COMMIT_MSG@7
PS6, Line 7: c
ah, now I understand what you meant. Sorry for being so tone-deaf. […]
I think Arthur's proposal is to use our pre-CAR code for doing the µcode update and then (in the scenarios that need it) run FSP-T which doesn't have to do the updates anymore. That way, we get rid of the layout requirement.
Doesn't that work?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38640
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c02601a7ac64078e556e2032baeccaf27f77da2
Gerrit-Change-Number: 38640
Gerrit-PatchSet: 8
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 18 Feb 2020 19:47:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Andrey Petrov
anpetrov@fb.com
Gerrit-MessageType: comment