Hello Angel Pons,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/47669
to review the following change.
Change subject: doc/relnotes/4.13: Add changes to log-level configurability ......................................................................
doc/relnotes/4.13: Add changes to log-level configurability
Change-Id: Ia7ef57d20ea5099f344ccbf58d76597cb0e82c85 Signed-off-by: Nico Huber nico.huber@secunet.com --- M Documentation/releases/coreboot-4.13-relnotes.md 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/47669/1
diff --git a/Documentation/releases/coreboot-4.13-relnotes.md b/Documentation/releases/coreboot-4.13-relnotes.md index 1eda23b..ca64815 100644 --- a/Documentation/releases/coreboot-4.13-relnotes.md +++ b/Documentation/releases/coreboot-4.13-relnotes.md @@ -80,6 +80,18 @@ Exceptional cases, that may still need early bus master enabling in the future, should get their own per-reason Kconfig option. Ideally before the next release.
+### Early runtime configurability of the console log level + +Traditionally, we didn't allow the log level of the `romstage` console +to be changed at runtime (e.g. via `get_option()`). It turned out that +the technical constraints for this (no global variables in `romstage`) +vanished long ago, though. The new behaviour is to query `get_option()` +now from the second stage that uses the console on. In other words, if +the `bootblock` already enables the console, the `romstage` log level +can be changed via `get_option()`. Keeping the log level of the first +console static, ensures that we can see console output even if there's +a bug in the more involved code to query options. + ### Add significant changes here
Deprecations
Hello Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47669
to look at the new patch set (#2).
Change subject: doc/relnotes/4.13: Add changes to log-level configurability ......................................................................
doc/relnotes/4.13: Add changes to log-level configurability
Change-Id: Ia7ef57d20ea5099f344ccbf58d76597cb0e82c85 Signed-off-by: Nico Huber nico.huber@secunet.com --- M Documentation/releases/coreboot-4.13-relnotes.md 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/47669/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47669 )
Change subject: doc/relnotes/4.13: Add changes to log-level configurability ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47669 )
Change subject: doc/relnotes/4.13: Add changes to log-level configurability ......................................................................
doc/relnotes/4.13: Add changes to log-level configurability
Change-Id: Ia7ef57d20ea5099f344ccbf58d76597cb0e82c85 Signed-off-by: Nico Huber nico.huber@secunet.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47669 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Documentation/releases/coreboot-4.13-relnotes.md 1 file changed, 12 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/Documentation/releases/coreboot-4.13-relnotes.md b/Documentation/releases/coreboot-4.13-relnotes.md index c9447a3..7c7102b 100644 --- a/Documentation/releases/coreboot-4.13-relnotes.md +++ b/Documentation/releases/coreboot-4.13-relnotes.md @@ -110,6 +110,18 @@ Exceptional cases, that may still need early bus master enabling in the future, should get their own per-reason Kconfig option. Ideally before the next release.
+### Early runtime configurability of the console log level + +Traditionally, we didn't allow the log level of the `romstage` console +to be changed at runtime (e.g. via `get_option()`). It turned out that +the technical constraints for this (no global variables in `romstage`) +vanished long ago, though. The new behaviour is to query `get_option()` +now from the second stage that uses the console on. In other words, if +the `bootblock` already enables the console, the `romstage` log level +can be changed via `get_option()`. Keeping the log level of the first +console static ensures that we can see console output even if there's +a bug in the more involved code to query options. + ### Add significant changes here
Deprecations
-
Angel Pons (Code Review) -
Nico Huber (Code Review)