Change in coreboot[master]: src/nb/i945: Fix "CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8" if statement

[Elyes HAOUAS (Code Review)]

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/28878 )

Change subject: src/nb/i945: Fix "CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8" if statement
......................................................................

Patch Set 3:
> > > Using #if is a bad habit. Also, what are the outer parentheses
>
> for?
> > If I'm not wrong, '#if' is used in (romstage) to bypass the code
>
> if
> > the statement is not true.
>
> You can use it like that. But that's not specific to any stage. And
> it's a bad choice because the guarded code won't be compile tested.
>
> There is no other way to do this in romcc bootblock code, maybe
> that is what you had in mind?

I mean this code is for debugging purpose only and probably we don't need
it in side the ROM.

I'm wondering if it will compile and if 'sdram_dump_mchbar_registers'
makes sense before RAM init.