Change in ...coreboot[master]: build system: Add various compiler flags that enable warnings on UB

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: docs:...

Patrick Georgi (Code Review)

15 May 2019 15 May '19

9:41 p.m.

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32814

Change subject: build system: Add various compiler flags that enable warnings on UB ......................................................................

build system: Add various compiler flags that enable warnings on UB

Some types of Undefined Behavior can be determined statically at compile time and gcc now has a set of flags that make it emit warnings in that case instead of doing the __builtin_trap() / optimize / UD2-opcode dance that silently breaks the resulting binary.

Change-Id: I3aa5ca00c9838cc7517160069310a1ef85372027 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/32814/1

diff --git a/Makefile.inc b/Makefile.inc index 9860da1..f2e010c 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -410,6 +410,8 @@ ifeq ($(CCC_ANALYZER_OUTPUT_FORMAT),) CFLAGS_common += -Wno-packed-not-aligned CFLAGS_common += -fconserve-stack +CFLAGS_common += -pedantic-errors -Wnull-dereference +CFLAGS_common += -Wno-aggressive-loop-optimizations -Wreturn-type # cf. commit f69a99db (coreboot: x86: enable gc-sections) CFLAGS_common += -Wno-unused-but-set-variable endif

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Patrick Georgi (Code Review)

15 May 15 May

9:41 p.m.

Hello Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32814

to look at the new patch set (#2).

Change subject: build system: Add various compiler flags that enable warnings on UB ......................................................................

build system: Add various compiler flags that enable warnings on UB

BUG=chromium:958270 BRANCH=none TEST=abuild passes (probably not)

Change-Id: I3aa5ca00c9838cc7517160069310a1ef85372027 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/32814/2

Aaron Durbin (Code Review)

9:43 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32814 )

Change subject: build system: Add various compiler flags that enable warnings on UB ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32814 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3aa5ca00c9838cc7517160069310a1ef85372027 Gerrit-Change-Number: 32814 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 15 May 2019 19:43:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

10:17 p.m.

Hello Aaron Durbin, build bot (Jenkins), Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32814

to look at the new patch set (#3).

Change subject: build system: Add various compiler flags that enable warnings on UB ......................................................................

build system: Add various compiler flags that enable warnings on UB

BUG=chromium:958270 BRANCH=none TEST=abuild passes (probably not)

Change-Id: I3aa5ca00c9838cc7517160069310a1ef85372027 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/32814/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/32814 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3aa5ca00c9838cc7517160069310a1ef85372027 Gerrit-Change-Number: 32814 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

18 Nov 18 Nov

1:06 p.m.

New subject: Change in coreboot[master]: build system: Add various compiler flags that enable warnings on UB

Hello Aaron Durbin, build bot (Jenkins), Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32814

to look at the new patch set (#4).

Change subject: build system: Add various compiler flags that enable warnings on UB ......................................................................

build system: Add various compiler flags that enable warnings on UB

BUG=chromium:958270 BRANCH=none TEST=abuild passes (probably not)

Change-Id: I3aa5ca00c9838cc7517160069310a1ef85372027 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/32814/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/32814 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3aa5ca00c9838cc7517160069310a1ef85372027 Gerrit-Change-Number: 32814 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Aaron Durbin (Code Review)

7:07 p.m.

New subject: Change in coreboot[master]: build system: Add various compiler flags that enable warnings on UB

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32814 )

Change subject: build system: Add various compiler flags that enable warnings on UB ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32814 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3aa5ca00c9838cc7517160069310a1ef85372027 Gerrit-Change-Number: 32814 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 18 Nov 2019 18:07:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

8:19 p.m.

New subject: Change in coreboot[master]: build system: Add various compiler flags that enable warnings on UB

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/32814 )

Change subject: build system: Add various compiler flags that enable warnings on UB ......................................................................

build system: Add various compiler flags that enable warnings on UB

BUG=chromium:958270 BRANCH=none TEST=abuild passes (probably not)

Change-Id: I3aa5ca00c9838cc7517160069310a1ef85372027 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32814 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org --- M Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved

diff --git a/Makefile.inc b/Makefile.inc index d3aa885..66144cd 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -419,6 +419,7 @@ ifeq ($(CCC_ANALYZER_OUTPUT_FORMAT),) CFLAGS_common += -Wno-packed-not-aligned CFLAGS_common += -fconserve-stack +CFLAGS_common += -Wnull-dereference -Wreturn-type # cf. commit f69a99db (coreboot: x86: enable gc-sections) CFLAGS_common += -Wno-unused-but-set-variable endif

-- To view, visit https://review.coreboot.org/c/coreboot/+/32814 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3aa5ca00c9838cc7517160069310a1ef85372027 Gerrit-Change-Number: 32814 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1824

days inactive

2011

days old

coreboot-gerrit@coreboot.org

6 comments

2 participants

tags (0)

participants (2)

Aaron Durbin (Code Review)
Patrick Georgi (Code Review)