[S] Change in coreboot[master]: soc/intel/meteorlake: Rename method is_eom to is_manuf_mode

[Kapil Porwal (Code Review)]

Attention is currently required from: Tarun Tuli, Subrata Banik.

Kapil Porwal has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69698 )

Change subject: soc/intel/meteorlake: Rename method is_eom to is_manuf_mode
......................................................................

soc/intel/meteorlake: Rename method is_eom to is_manuf_mode

BUG=none
TEST=Build and boot to google/rex.

Excerpt from google/rex coreboot log:
[DEBUG]  ME: Manufacturing Mode          : YES

Signed-off-by: Kapil Porwal 
Change-Id: I8d2de3365126ba618c987c412c4e9784012f9e0b
---
M src/soc/intel/meteorlake/me.c
1 file changed, 27 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/69698/1

diff --git a/src/soc/intel/meteorlake/me.c b/src/soc/intel/meteorlake/me.c
index 743e963..68cb62c 100644
--- a/src/soc/intel/meteorlake/me.c
+++ b/src/soc/intel/meteorlake/me.c
@@ -76,16 +76,15 @@
    } __packed fields;
 };

-
-/*
- * Manufacturing mode is disabled if the descriptor is locked, fuses
- * are programmed and manufacturing variables are locked.
- * The function returns true if manufacturing mode is disabled otherwise false.
- */
-static bool is_eom(union me_hfsts1 hfsts1, union me_hfsts6 hfsts6)
+static bool is_manuf_mode(union me_hfsts1 hfsts1, union me_hfsts6 hfsts6)
 {
-	return (hfsts1.fields.mfg_mode == 0) && (hfsts6.fields.manuf_lock == 1) &&
-		(hfsts6.fields.fpf_soc_lock == 1);
+	/*
+	 * ME manufacturing mode is disabled if the descriptor is locked, fuses
+	 * are programmed and manufacturing variables are locked.
+	 */
+	return !((hfsts1.fields.mfg_mode == 0) &&
+		 (hfsts6.fields.fpf_soc_lock == 1) &&
+		 (hfsts6.fields.manuf_lock == 1));
 }

static void dump_me_status(void *unused)
@@ -96,6 +95,7 @@
    union me_hfsts4 hfsts4;
    union me_hfsts5 hfsts5;
    union me_hfsts6 hfsts6;
+	bool manuf_mode;

if (!is_cse_enabled())
    	return;
@@ -114,8 +114,9 @@
    printk(BIOS_DEBUG, "ME: HFSTS5                      : 0x%08X\n", hfsts5.data);
    printk(BIOS_DEBUG, "ME: HFSTS6                      : 0x%08X\n", hfsts6.data);

+	manuf_mode = is_manuf_mode(hfsts1, hfsts6);
    printk(BIOS_DEBUG, "ME: Manufacturing Mode          : %s\n",
-			is_eom(hfsts1, hfsts6) ? "NO" : "YES");
+	       manuf_mode ? "YES" : "NO");

/*
     * The SPI Protection Mode bit reflects SPI descriptor