Change in coreboot[master]: mb/google/hatch: Override board_get_usb_typec_port_paths on Kohaku

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: Update...

Tim Wawrzynczak (Code Review)

28 Jan 2020 28 Jan '20

8:50 p.m.

Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38618 )

Change subject: mb/google/hatch: Override board_get_usb_typec_port_paths on Kohaku ......................................................................

mb/google/hatch: Override board_get_usb_typec_port_paths on Kohaku

Override board_get_usb_typec_port_paths on Kohaku so that the SSDT generator for the EC can add references to the USB port objects in the _DSD for each connector object.

BUG=b:146506369 BRANCH=none TEST=Disassemble SSDT and verify

Change-Id: Ide244ac47c439b8fae90cc842c0805cd17640556 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/kohaku/ramstage.c 1 file changed, 24 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/38618/1

diff --git a/src/mainboard/google/hatch/variants/kohaku/ramstage.c b/src/mainboard/google/hatch/variants/kohaku/ramstage.c index 9b919fc..9cd0f7e 100644 --- a/src/mainboard/google/hatch/variants/kohaku/ramstage.c +++ b/src/mainboard/google/hatch/variants/kohaku/ramstage.c @@ -17,6 +17,7 @@ #include <gpio.h> #include <baseboard/variants.h> #include <soc/gpio.h> +#include <ec/google/chromeec/ec.h>

void variant_ramstage_init(void) { @@ -30,3 +31,26 @@ mdelay(1); gpio_output(GPP_A12, 1); } + +static struct device_path usb_port_paths[][2] = +{ + { + {.type=DEVICE_PATH_USB, {.usb={ .port_type = 2, .port_id = 0 }}}, + {.type=DEVICE_PATH_USB, {.usb={ .port_type = 3, .port_id = 0 }}}, + }, + { + {.type=DEVICE_PATH_USB, {.usb={ .port_type = 2, .port_id = 1 }}}, + {.type=DEVICE_PATH_USB, {.usb={ .port_type = 3, .port_id = 1 }}}, + } +}; + +struct device_path *board_get_usb_typec_port_paths(int port, int *devices) +{ + if (port < 0 || port > 1) + return NULL; + + /* 2 devices for each port */ + *devices = 2; + + return usb_port_paths[port]; +}

Attachments:

attachment.htm (text/html — 4.5 KB)

Show replies by date

build bot (Jenkins) (Code Review)

28 Jan 28 Jan

8:50 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38618 )

Change subject: mb/google/hatch: Override board_get_usb_typec_port_paths on Kohaku ......................................................................

Patch Set 1:

(13 comments)

https://review.coreboot.org/c/coreboot/+/38618/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/ramstage.c:

https://review.coreboot.org/c/coreboot/+/38618/1/src/mainboard/google/hatch/... PS1, Line 36: { that open brace { should be on the previous line

https://review.coreboot.org/c/coreboot/+/38618/1/src/mainboard/google/hatch/... PS1, Line 38: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 2, .port_id = 0 }}}, spaces required around that '=' (ctx:VxV)

https://review.coreboot.org/c/coreboot/+/38618/1/src/mainboard/google/hatch/... PS1, Line 39: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 3, .port_id = 0 }}}, spaces required around that '=' (ctx:VxV)

https://review.coreboot.org/c/coreboot/+/38618/1/src/mainboard/google/hatch/... PS1, Line 42: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 2, .port_id = 1 }}}, spaces required around that '=' (ctx:VxV)

https://review.coreboot.org/c/coreboot/+/38618/1/src/mainboard/google/hatch/... PS1, Line 43: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 3, .port_id = 1 }}}, spaces required around that '=' (ctx:VxV)

Tim Wawrzynczak (Code Review)

8:52 p.m.

Hello Shelley Chen, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38618

to look at the new patch set (#2).

Change subject: mb/google/hatch: Override board_get_usb_typec_port_paths on Kohaku ......................................................................

mb/google/hatch: Override board_get_usb_typec_port_paths on Kohaku

Override board_get_usb_typec_port_paths on Kohaku so that the SSDT generator for the EC can add references to the USB port objects in the _DSD for each connector object.

BUG=b:146506369 BRANCH=none TEST=Disassemble SSDT and verify

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/38618/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38618 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide244ac47c439b8fae90cc842c0805cd17640556 Gerrit-Change-Number: 38618 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

9:49 p.m.

Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38618

to look at the new patch set (#5).

Change subject: mb/google/hatch: Override board_get_usb_typec_port_paths on Kohaku ......................................................................

mb/google/hatch: Override board_get_usb_typec_port_paths on Kohaku

Override board_get_usb_typec_port_paths on Kohaku so that the SSDT generator for the EC can add references to the USB port objects in the _DSD for each connector object.

BUG=b:146506369 BRANCH=none TEST=Disassemble SSDT and verify

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/38618/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/38618 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide244ac47c439b8fae90cc842c0805cd17640556 Gerrit-Change-Number: 38618 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Paul Menzel (Code Review)

30 Jan 30 Jan

10:51 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38618 )

Change subject: mb/google/hatch: Override board_get_usb_typec_port_paths on Kohaku ......................................................................

Patch Set 9:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38618/9//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38618/9//COMMIT_MSG@11 PS9, Line 11: in the _DSD for each connector object. More words fit on the line above.

https://review.coreboot.org/c/coreboot/+/38618/9/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/ramstage.c:

https://review.coreboot.org/c/coreboot/+/38618/9/src/mainboard/google/hatch/... PS9, Line 37: {.type = DEVICE_PATH_USB, {.usb = { .port_type = 2, .port_id = 0 } } }, Space in `{ .type = ` and so on?

-- To view, visit https://review.coreboot.org/c/coreboot/+/38618 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide244ac47c439b8fae90cc842c0805cd17640556 Gerrit-Change-Number: 38618 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 30 Jan 2020 09:51:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

5:14 p.m.

Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38618

to look at the new patch set (#10).

Change subject: mb/google/hatch: Override board_get_usb_typec_port_paths on Kohaku ......................................................................

mb/google/hatch: Override board_get_usb_typec_port_paths on Kohaku

Override board_get_usb_typec_port_paths on Kohaku so that the SSDT generator for the EC can add references to the USB port objects in the _DSD for each connector object.

BUG=b:146506369 BRANCH=none TEST=Disassemble SSDT and verify

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/38618/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/38618 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide244ac47c439b8fae90cc842c0805cd17640556 Gerrit-Change-Number: 38618 Gerrit-PatchSet: 10 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

5:14 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38618 )

Change subject: mb/google/hatch: Override board_get_usb_typec_port_paths on Kohaku ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38618/9/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/ramstage.c:

https://review.coreboot.org/c/coreboot/+/38618/9/src/mainboard/google/hatch/... PS9, Line 37: {.type = DEVICE_PATH_USB, {.usb = { .port_type = 2, .port_id = 0 } } },

...

Space in `{ . […]

Thanks for keeping me honest paul :)

-- To view, visit https://review.coreboot.org/c/coreboot/+/38618 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide244ac47c439b8fae90cc842c0805cd17640556 Gerrit-Change-Number: 38618 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 30 Jan 2020 16:14:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

5:15 p.m.

Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38618

to look at the new patch set (#11).

Change subject: mb/google/hatch: Override board_get_usb_typec_port_paths on Kohaku ......................................................................

mb/google/hatch: Override board_get_usb_typec_port_paths on Kohaku

Override board_get_usb_typec_port_paths on Kohaku so that the SSDT generator for the EC can add references to the USB port objects in the _DSD for each connector object.

BUG=b:146506369 BRANCH=none TEST=Disassemble SSDT and verify

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/38618/11

-- To view, visit https://review.coreboot.org/c/coreboot/+/38618 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide244ac47c439b8fae90cc842c0805cd17640556 Gerrit-Change-Number: 38618 Gerrit-PatchSet: 11 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

3 Feb 3 Feb

7:34 p.m.

Tim Wawrzynczak has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38618 )

Change subject: mb/google/hatch: Override board_get_usb_typec_port_paths on Kohaku ......................................................................

Abandoned

Going with different approach, see CB:38683

-- To view, visit https://review.coreboot.org/c/coreboot/+/38618 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide244ac47c439b8fae90cc842c0805cd17640556 Gerrit-Change-Number: 38618 Gerrit-PatchSet: 11 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1755

days inactive

1761

days old

coreboot-gerrit@coreboot.org

8 comments

3 participants

tags (0)

participants (3)

build bot (Jenkins) (Code Review)
Paul Menzel (Code Review)
Tim Wawrzynczak (Code Review)