View Change

13 comments:

• File src/mainboard/google/hatch/variants/kohaku/ramstage.c:

  • Patch Set #1, Line 36: {

    that open brace { should be on the previous line

  • Patch Set #1, Line 38: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 2, .port_id = 0 }}},

    spaces required around that '=' (ctx:VxV)

  • Patch Set #1, Line 38: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 2, .port_id = 0 }}},

    spaces required around that '=' (ctx:VxV)

  • Patch Set #1, Line 38: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 2, .port_id = 0 }}},

    space required after that close brace '}'

  • Patch Set #1, Line 39: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 3, .port_id = 0 }}},

    spaces required around that '=' (ctx:VxV)

  • Patch Set #1, Line 39: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 3, .port_id = 0 }}},

    spaces required around that '=' (ctx:VxV)

  • Patch Set #1, Line 39: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 3, .port_id = 0 }}},

    space required after that close brace '}'

  • Patch Set #1, Line 42: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 2, .port_id = 1 }}},

    spaces required around that '=' (ctx:VxV)

  • Patch Set #1, Line 42: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 2, .port_id = 1 }}},

    spaces required around that '=' (ctx:VxV)

  • Patch Set #1, Line 42: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 2, .port_id = 1 }}},

    space required after that close brace '}'

  • Patch Set #1, Line 43: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 3, .port_id = 1 }}},

    spaces required around that '=' (ctx:VxV)

  • Patch Set #1, Line 43: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 3, .port_id = 1 }}},

    spaces required around that '=' (ctx:VxV)

  • Patch Set #1, Line 43: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 3, .port_id = 1 }}},

    space required after that close brace '}'

To view, visit change 38618. To unsubscribe, or for help writing mail filters, visit settings.