HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33659
Change subject: drivers: Add missing #include <commonlib/helpers.h> ......................................................................
drivers: Add missing #include <commonlib/helpers.h>
ALIGN and ALIGN_UP needs 'helpers.h
Change-Id: Ia18f69b58bae6d841d800dc38745ff27f51cec46 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/amd/agesa/mtrr_fixme.c M src/drivers/intel/fsp1_1/car.c M src/drivers/intel/fsp1_1/fsp_util.c M src/drivers/intel/fsp1_1/raminit.c M src/drivers/smmstore/store.c 5 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/33659/1
diff --git a/src/drivers/amd/agesa/mtrr_fixme.c b/src/drivers/amd/agesa/mtrr_fixme.c index 1fbb553..fcb353c 100644 --- a/src/drivers/amd/agesa/mtrr_fixme.c +++ b/src/drivers/amd/agesa/mtrr_fixme.c @@ -14,6 +14,7 @@ #include <arch/cpu.h> #include <cbmem.h> #include <console/console.h> +#include <commonlib/helpers.h> #include <cpu/amd/mtrr.h> #include <cpu/cpu.h> #include <cpu/x86/cache.h> diff --git a/src/drivers/intel/fsp1_1/car.c b/src/drivers/intel/fsp1_1/car.c index 67ed099..bd3f478 100644 --- a/src/drivers/intel/fsp1_1/car.c +++ b/src/drivers/intel/fsp1_1/car.c @@ -15,6 +15,7 @@
#include <arch/symbols.h> #include <console/console.h> +#include <commonlib/helpers.h> #include <cpu/intel/romstage.h> #include <cpu/x86/mtrr.h> #include <fsp/car.h> diff --git a/src/drivers/intel/fsp1_1/fsp_util.c b/src/drivers/intel/fsp1_1/fsp_util.c index 2702b5a..ab9f28f 100644 --- a/src/drivers/intel/fsp1_1/fsp_util.c +++ b/src/drivers/intel/fsp1_1/fsp_util.c @@ -16,6 +16,7 @@
#include <bootstate.h> #include <cbmem.h> +#include <commonlib/helpers.h> #include <console/console.h> #include <console/streams.h> #include <fsp/util.h> diff --git a/src/drivers/intel/fsp1_1/raminit.c b/src/drivers/intel/fsp1_1/raminit.c index eff011a..803492f 100644 --- a/src/drivers/intel/fsp1_1/raminit.c +++ b/src/drivers/intel/fsp1_1/raminit.c @@ -17,6 +17,7 @@ #include <arch/acpi.h> #include <cbmem.h> #include <cf9_reset.h> +#include <commonlib/helpers.h> #include <console/console.h> #include <fsp/memmap.h> #include <fsp/romstage.h> diff --git a/src/drivers/smmstore/store.c b/src/drivers/smmstore/store.c index 6f2014b..833407d 100644 --- a/src/drivers/smmstore/store.c +++ b/src/drivers/smmstore/store.c @@ -16,6 +16,7 @@ #include <boot_device.h> #include <cbfs.h> #include <fmap.h> +#include <commonlib/helpers.h> #include <commonlib/region.h> #include <console/console.h> #include <smmstore.h>
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33659 )
Change subject: drivers: Add missing #include <commonlib/helpers.h> ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33659 )
Change subject: drivers: Add missing #include <commonlib/helpers.h> ......................................................................
drivers: Add missing #include <commonlib/helpers.h>
ALIGN and ALIGN_UP needs 'helpers.h
Change-Id: Ia18f69b58bae6d841d800dc38745ff27f51cec46 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33659 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/drivers/amd/agesa/mtrr_fixme.c M src/drivers/intel/fsp1_1/car.c M src/drivers/intel/fsp1_1/fsp_util.c M src/drivers/intel/fsp1_1/raminit.c M src/drivers/smmstore/store.c 5 files changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/drivers/amd/agesa/mtrr_fixme.c b/src/drivers/amd/agesa/mtrr_fixme.c index 1fbb553..fcb353c 100644 --- a/src/drivers/amd/agesa/mtrr_fixme.c +++ b/src/drivers/amd/agesa/mtrr_fixme.c @@ -14,6 +14,7 @@ #include <arch/cpu.h> #include <cbmem.h> #include <console/console.h> +#include <commonlib/helpers.h> #include <cpu/amd/mtrr.h> #include <cpu/cpu.h> #include <cpu/x86/cache.h> diff --git a/src/drivers/intel/fsp1_1/car.c b/src/drivers/intel/fsp1_1/car.c index 67ed099..bd3f478 100644 --- a/src/drivers/intel/fsp1_1/car.c +++ b/src/drivers/intel/fsp1_1/car.c @@ -15,6 +15,7 @@
#include <arch/symbols.h> #include <console/console.h> +#include <commonlib/helpers.h> #include <cpu/intel/romstage.h> #include <cpu/x86/mtrr.h> #include <fsp/car.h> diff --git a/src/drivers/intel/fsp1_1/fsp_util.c b/src/drivers/intel/fsp1_1/fsp_util.c index 2702b5a..ab9f28f 100644 --- a/src/drivers/intel/fsp1_1/fsp_util.c +++ b/src/drivers/intel/fsp1_1/fsp_util.c @@ -16,6 +16,7 @@
#include <bootstate.h> #include <cbmem.h> +#include <commonlib/helpers.h> #include <console/console.h> #include <console/streams.h> #include <fsp/util.h> diff --git a/src/drivers/intel/fsp1_1/raminit.c b/src/drivers/intel/fsp1_1/raminit.c index a631fca..7c20b25 100644 --- a/src/drivers/intel/fsp1_1/raminit.c +++ b/src/drivers/intel/fsp1_1/raminit.c @@ -17,6 +17,7 @@ #include <arch/acpi.h> #include <cbmem.h> #include <cf9_reset.h> +#include <commonlib/helpers.h> #include <console/console.h> #include <fsp/memmap.h> #include <fsp/romstage.h> diff --git a/src/drivers/smmstore/store.c b/src/drivers/smmstore/store.c index 6f2014b..833407d 100644 --- a/src/drivers/smmstore/store.c +++ b/src/drivers/smmstore/store.c @@ -16,6 +16,7 @@ #include <boot_device.h> #include <cbfs.h> #include <fmap.h> +#include <commonlib/helpers.h> #include <commonlib/region.h> #include <console/console.h> #include <smmstore.h>