Attention is currently required from: Paul Menzel.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84736?usp=email )
Change subject: mb/starlabs/*: Set all I2C speeds to fast
......................................................................
Patch Set 7:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84736/comment/1cd99536_4e3c89a9?usp... :
PS6, Line 9: driver
which driver? Linux?
Done
https://review.coreboot.org/c/coreboot/+/84736/comment/fe1ab798_7c117765?usp... :
PS6, Line 13: negligable
spelling
Done
https://review.coreboot.org/c/coreboot/+/84736/comment/3d51afb4_7a25711e?usp... :
PS6, Line 14: option to configure it.
"unused option" ?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84736?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic722e971e6f94965d28fd158a46d144a19490199
Gerrit-Change-Number: 84736
Gerrit-PatchSet: 7
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 07 Jan 2025 08:57:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com