Change in coreboot[master]: mb/intel/icelake_rvp: Remove unused mainboard ACPI write table

[Aamir Bohra (Code Review)]

Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37354 )

Change subject: mb/intel/icelake_rvp: Remove unused mainboard ACPI write table
......................................................................

mb/intel/icelake_rvp: Remove unused mainboard ACPI write table

Change-Id: I19040cca064c2ce063aab77391e0577271c6e9dc
Signed-off-by: Aamir Bohra 
---
M src/mainboard/intel/icelake_rvp/mainboard.c
1 file changed, 0 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/37354/1

diff --git a/src/mainboard/intel/icelake_rvp/mainboard.c b/src/mainboard/intel/icelake_rvp/mainboard.c
index 36d6a3e..8e51e45 100644
--- a/src/mainboard/intel/icelake_rvp/mainboard.c
+++ b/src/mainboard/intel/icelake_rvp/mainboard.c
@@ -29,20 +29,8 @@
    gpio_configure_pads(pads, num);
 }

-static unsigned long mainboard_write_acpi_tables(struct device *device,
-						 unsigned long current,
-						 acpi_rsdp_t *rsdp)
-{
-	uintptr_t start_addr;
-
-	start_addr = current;
-
-	return start_addr;
-}
-
 static void mainboard_enable(struct device *dev)
 {
-	dev->ops->write_acpi_tables = mainboard_write_acpi_tables;
    dev->ops->acpi_inject_dsdt_generator = chromeos_dsdt_generator;
 }

[Rizwan Qureshi (Code Review)]

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37354 )

Change subject: mb/intel/icelake_rvp: Remove unused mainboard ACPI write table
......................................................................

Patch Set 1: Code-Review+2

[Lean Sheng Tan (Code Review)]

Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37354 )

Change subject: mb/intel/icelake_rvp: Remove unused mainboard ACPI write table
......................................................................

Patch Set 1: Code-Review+1

[Ronak Kanabar (Code Review)]

Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37354 )

Change subject: mb/intel/icelake_rvp: Remove unused mainboard ACPI write table
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37354 )

Change subject: mb/intel/icelake_rvp: Remove unused mainboard ACPI write table
......................................................................

mb/intel/icelake_rvp: Remove unused mainboard ACPI write table

Change-Id: I19040cca064c2ce063aab77391e0577271c6e9dc
Signed-off-by: Aamir Bohra 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37354
Tested-by: build bot (Jenkins) 
Reviewed-by: Rizwan Qureshi 
Reviewed-by: Lean Sheng Tan 
Reviewed-by: Ronak Kanabar 
---
M src/mainboard/intel/icelake_rvp/mainboard.c
1 file changed, 0 insertions(+), 12 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Rizwan Qureshi: Looks good to me, approved
  Lean Sheng Tan: Looks good to me, but someone else must approve
  Ronak Kanabar: Looks good to me, approved

diff --git a/src/mainboard/intel/icelake_rvp/mainboard.c b/src/mainboard/intel/icelake_rvp/mainboard.c
index 36d6a3e..8e51e45 100644
--- a/src/mainboard/intel/icelake_rvp/mainboard.c
+++ b/src/mainboard/intel/icelake_rvp/mainboard.c
@@ -29,20 +29,8 @@
    gpio_configure_pads(pads, num);
 }

-static unsigned long mainboard_write_acpi_tables(struct device *device,
-						 unsigned long current,
-						 acpi_rsdp_t *rsdp)
-{
-	uintptr_t start_addr;
-
-	start_addr = current;
-
-	return start_addr;
-}
-
 static void mainboard_enable(struct device *dev)
 {
-	dev->ops->write_acpi_tables = mainboard_write_acpi_tables;
    dev->ops->acpi_inject_dsdt_generator = chromeos_dsdt_generator;
 }