Change in coreboot[master]: soc/intel/common/block/cse: Modify heci_send_receive to support MCHI ...

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46881 )

Change subject: soc/intel/common/block/cse: Modify heci_send_receive to support MCHI address
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46881/5/src/soc/intel/common/block/... 
File src/soc/intel/common/block/cse/cse.c:

https://review.coreboot.org/c/coreboot/+/46881/5/src/soc/intel/common/block/... 
PS5, Line 537: p = snd_msg
This can be initialized in the previous line itself.

https://review.coreboot.org/c/coreboot/+/46881/5/src/soc/intel/common/block/... 
PS5, Line 539: 	if (p->group_id == MCHI_GROUP_ID_MCA) {
             : 		if (!heci_send(snd_msg, snd_sz, BIOS_HOST_ADDR, HECI_MCHI_ADDR)) {
             : 			printk(BIOS_ERR, "HECI: send Failed\n");
             : 			return 0;
             : 		}
             : 	} else {
             : 		if (!heci_send(snd_msg, snd_sz, BIOS_HOST_ADDR, HECI_MKHI_ADDR)) {
             : 			printk(BIOS_ERR, "HECI: send Failed\n");
             : 			return 0;
             : 		}
             : 	}
This can be simplified further:

uint8_t clnt_addr = p->group_id == MCHI_GROUP_ID_MCA ? HECI_MCHI_ADDR : HECI_MKHI_ADDR;

if (!heci_send(snd_msg, snd_sz, BIOS_HOST_ADDR, clnt_addr)) {
    printk(BIOS_ERR, "HECI: send Failed for clnt_addr: %02x\n", clnt_addr);
    return 0;
}