View Change

2 comments:

• File src/soc/intel/common/block/cse/cse.c:

  • Patch Set #5, Line 537: p = snd_msg

    This can be initialized in the previous line itself.

  • Patch Set #5, Line 539:

    	if (p->group_id == MCHI_GROUP_ID_MCA) {
    		if (!heci_send(snd_msg, snd_sz, BIOS_HOST_ADDR, HECI_MCHI_ADDR)) {
    			printk(BIOS_ERR, "HECI: send Failed\n");
    			return 0;
    		}
    	} else {
    		if (!heci_send(snd_msg, snd_sz, BIOS_HOST_ADDR, HECI_MKHI_ADDR)) {
    			printk(BIOS_ERR, "HECI: send Failed\n");
    			return 0;
    		}
    	}
    

    This can be simplified further:

    uint8_t clnt_addr = p->group_id == MCHI_GROUP_ID_MCA ? HECI_MCHI_ADDR : HECI_MKHI_ADDR;

    if (!heci_send(snd_msg, snd_sz, BIOS_HOST_ADDR, clnt_addr)) {
        printk(BIOS_ERR, "HECI: send Failed for clnt_addr: %02x\n", clnt_addr);
        return 0;
    }

To view, visit change 46881. To unsubscribe, or for help writing mail filters, visit settings.