Change in coreboot[master]: UPSTREAM: mb/google/volteer/variants/delbin: Update DPTF parameters f...
Deepika Punyamurtula has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46676 )
Change subject: UPSTREAM: mb/google/volteer/variants/delbin: Update DPTF parameters for delbin ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46676/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46676/4/src/mainboard/google/voltee... PS4, Line 10: register "policies.active" = "{ : [0] = {.target = DPTF_CPU, : .thresholds = {TEMP_PCT(0, 0), : TEMP_PCT(0, 0), : TEMP_PCT(0, 0), : TEMP_PCT(0, 0), : TEMP_PCT(0, 0),}}, : [1] = {.target = DPTF_TEMP_SENSOR_0, : .thresholds = {TEMP_PCT(0, 0), : TEMP_PCT(0, 0), : TEMP_PCT(0, 0), : TEMP_PCT(0, 0), : TEMP_PCT(0, 0),}}, : [2] = {.target = DPTF_TEMP_SENSOR_1, : .thresholds = {TEMP_PCT(0, 0), : TEMP_PCT(0, 0), : TEMP_PCT(0, 0), : TEMP_PCT(0, 0), : TEMP_PCT(0, 0),}}, : [3] = {.target = DPTF_TEMP_SENSOR_2, : .thresholds = {TEMP_PCT(0, 0), : TEMP_PCT(0, 0), : TEMP_PCT(0, 0), : TEMP_PCT(0, 0), : TEMP_PCT(0, 0),}}, : [4] = {.target = DPTF_TEMP_SENSOR_3, : .thresholds = {TEMP_PCT(57, 90), : TEMP_PCT(47, 80), : TEMP_PCT(40, 70), : TEMP_PCT(36, 60), : TEMP_PCT(34, 50), : TEMP_PCT(30, 40),}}}" I believe this can be changed to register "policies.active" = "{ [0] = {.target = DPTF_TEMP_SENSOR_3, .thresholds = {TEMP_PCT(57, 90), TEMP_PCT(47, 80), TEMP_PCT(40, 70), TEMP_PCT(36, 60), TEMP_PCT(34, 50), TEMP_PCT(30, 40),}}}"
https://review.coreboot.org/c/coreboot/+/46676/4/src/mainboard/google/voltee... PS4, Line 53: 105 Is this supposed to be 100 as shared in the report on the bug?
-
Deepika Punyamurtula (Code Review)