Attention is currently required from: Arthur Heymans, Kyösti Mälkki. Hello Arthur Heymans, Kyösti Mälkki,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/53977
to review the following change.
Change subject: device: Drop unused `uma_memory_{base,size}` globals ......................................................................
device: Drop unused `uma_memory_{base,size}` globals
These global variables are not used anywhere. Drop them.
Change-Id: I3fe60b970153d913ae7b005257e2b53647d6f343 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/device/device.c M src/include/device/device.h 2 files changed, 0 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/53977/1
diff --git a/src/device/device.c b/src/device/device.c index aa10d6f..5611022 100644 --- a/src/device/device.c +++ b/src/device/device.c @@ -66,12 +66,6 @@
DECLARE_SPIN_LOCK(dev_lock)
-#if CONFIG(GFXUMA) -/* IGD UMA memory */ -uint64_t uma_memory_base = 0; -uint64_t uma_memory_size = 0; -#endif - /** * Allocate a new device structure. * diff --git a/src/include/device/device.h b/src/include/device/device.h index 01e2c82..88b5310 100644 --- a/src/include/device/device.h +++ b/src/include/device/device.h @@ -168,12 +168,6 @@
extern const char mainboard_name[];
-#if CONFIG(GFXUMA) -/* IGD UMA memory */ -extern uint64_t uma_memory_base; -extern uint64_t uma_memory_size; -#endif - /* Generic device interface functions */ struct device *alloc_dev(struct bus *parent, struct device_path *path); void dev_initialize_chips(void);