[S] Change in coreboot[main]: soc/intel/xeon_sp: Use fixed BDF for IBL

[Shuo Liu (Code Review)]

Attention is currently required from: Arthur Heymans, Christian Walter, David Hendricks, Johnny Lin, Jonathan Zhang, Jérémy Compostella, Lean Sheng Tan, Patrick Rudolph, TangYiwei, Tim Chu.

Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81321?usp=email )

Change subject: soc/intel/xeon_sp: Use fixed BDF for IBL
......................................................................

Patch Set 8:

(6 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/81321/comment/1c089f5f_cf6aeb9c :
PS8, Line 8:
> In general, I am in favor of using the full name of an acronym the first time it is being used in do […]

Acknowledged

https://review.coreboot.org/c/coreboot/+/81321/comment/078c5996_1ebbbd48 :
PS8, Line 9: IBL codes doesn't support bootloader controlled P2SB hidden and
> s/IBL/Intermediate Bootloader (IBL)/

Done

https://review.coreboot.org/c/coreboot/+/81321/comment/3d28bffe_84287300 :
PS8, Line 10: unhidden. Hence, dyanmically read IBL HPET/IOAPIC BDF by
> s/BDF/Bus:Device. […]

Done

https://review.coreboot.org/c/coreboot/+/81321/comment/5359aaa2_2be40b59 :
PS8, Line 11: bootloader is not supported, because when P2SB is hidden the
> s/P2SB/Primary-to-Sideband Bridge (P2SB)/

Done

File src/soc/intel/xeon_sp/util.c:

https://review.coreboot.org/c/coreboot/+/81321/comment/7d1e6097_85cc6801 :
PS8, Line 95: 	if (CONFIG(SOC_INTEL_COMMON_IBL_BASE)) {
> line length limit in coreboot is 96 characters. I don't know why checkpatch did not catch that. […]

Done

https://review.coreboot.org/c/coreboot/+/81321/comment/b15e0fee_5152708c :
PS8, Line 105: 		union p2sb_bdf bdf = {.bus = PCH_IOAPIC_BUS_NUMBER, .dev = PCH_IOAPIC_DEV_NUM, .fn = PCH_IOAPIC_FUNC_NUM};
> same here.

Done